Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 28230: Make sure filter buffer is flushed after it fills its output quota... (Closed)

Created:
11 years, 10 months ago by Mark Larson
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make sure filter buffer is flushed after it fills its output quota In some cases, when the filter returned but the output buffer was full, the ReadFilteredData code was not "bothering" to call the filter again (because there was no more input data to provide). We now maintain state indicating that the output buffer was filled (last time) and use that to ensure we call the filter(s) again when Read is next called. bug=7985 Original Review URL: http://codereview.chromium.org/27073 (Merge r10244 to the release branch) R= jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10538

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M net/url_request/url_request_job.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 5 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Larson
11 years, 10 months ago (2009-02-26 23:49:03 UTC) #1
jar (doing other things)
11 years, 9 months ago (2009-03-01 05:20:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698