Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: net/url_request/url_request_job.h

Issue 28230: Make sure filter buffer is flushed after it fills its output quota... (Closed) Base URL: svn://chrome-svn/chrome/branches/release_154.next/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 // out. 286 // out.
287 bool FilterHasData(); 287 bool FilterHasData();
288 288
289 // Indicates that the job is done producing data, either it has completed 289 // Indicates that the job is done producing data, either it has completed
290 // all the data or an error has been encountered. Set exclusively by 290 // all the data or an error has been encountered. Set exclusively by
291 // NotifyDone so that it is kept in sync with the request. 291 // NotifyDone so that it is kept in sync with the request.
292 bool done_; 292 bool done_;
293 293
294 // The data stream filter which is enabled on demand. 294 // The data stream filter which is enabled on demand.
295 scoped_ptr<Filter> filter_; 295 scoped_ptr<Filter> filter_;
296
297 // If the filter filled its output buffer, then there is a change that it
298 // still has internal data to emit, and this flag is set.
299 bool filter_needs_more_output_space_;
300
296 // When we filter data, we receive data into the filter buffers. After 301 // When we filter data, we receive data into the filter buffers. After
297 // processing the filtered data, we return the data in the caller's buffer. 302 // processing the filtered data, we return the data in the caller's buffer.
298 // While the async IO is in progress, we save the user buffer here, and 303 // While the async IO is in progress, we save the user buffer here, and
299 // when the IO completes, we fill this in. 304 // when the IO completes, we fill this in.
300 char *read_buffer_; 305 char *read_buffer_;
301 int read_buffer_len_; 306 int read_buffer_len_;
302 307
303 // Used by HandleResponseIfNecessary to track whether we've sent the 308 // Used by HandleResponseIfNecessary to track whether we've sent the
304 // OnResponseStarted callback and potentially redirect callbacks as well. 309 // OnResponseStarted callback and potentially redirect callbacks as well.
305 bool has_handled_response_; 310 bool has_handled_response_;
306 311
307 // Expected content size 312 // Expected content size
308 int64 expected_content_size_; 313 int64 expected_content_size_;
309 314
310 DISALLOW_COPY_AND_ASSIGN(URLRequestJob); 315 DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
311 }; 316 };
312 317
313 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_H_ 318 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_H_
314 319
OLDNEW
« no previous file with comments | « no previous file | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698