Implement displayName and stageParameters of VRDisplay for OpenVRDevice

Implement displayName and stageParameters of VRDisplay for OpenVRDevice

BUG=712181
Review-Url: https://codereview.chromium.org/2822983002
Cr-Commit-Position: refs/heads/master@{#465657}
Committed: https://chromium.googlesource.com/chromium/src/+/4774072a7a9b4b64adb17234eaadc922d1409439

[nhu, 2017-04-17 14:47:09]

Description was changed from

==========
Implement displayName and stageParameters of VRDisplay for OpenVRDevice

BUG=712181
==========

to

==========
Implement displayName and stageParameters of VRDisplay for OpenVRDevice

BUG=712181
==========

[nhu, 2017-04-17 14:47:10]

ningxin.hu@intel.com changed reviewers:
+ bajones@chromium.org, billorr@chromium.org

[nhu, 2017-04-17 14:47:27]

PTAL. Thanks!

[billorr, 2017-04-17 17:56:08]

change lgtm, but you'll need Brandond to sign off as owner.

https://codereview.chromium.org/2822983002/diff/1/device/vr/openvr/openvr_dev...
File device/vr/openvr/openvr_device.cc (right):

https://codereview.chromium.org/2822983002/diff/1/device/vr/openvr/openvr_dev...
device/vr/openvr/openvr_device.cc:123: transform[15] = 1.0f;
converting transforms from openvr to mojo/webvr format should be a helper like
the fov and vector conversions

[bajones, 2017-04-17 18:09:43]

LGTM as well, though I agree with Bill that the Matrix conversion should be a
helper function.

[nhu, 2017-04-18 01:39:58]

On 2017/04/17 18:09:43, bajones wrote:
> LGTM as well, though I agree with Bill that the Matrix conversion should be a
> helper function.

I've updated it with matrix conversion helper
(HmdMatrix34ToWebVRTransformMatrix).

Please take another look. Thanks!

[nhu, 2017-04-19 02:27:27]

On 2017/04/18 01:39:58, nhu wrote:
> On 2017/04/17 18:09:43, bajones wrote:
> > LGTM as well, though I agree with Bill that the Matrix conversion should be
a
> > helper function.
> 
> I've updated it with matrix conversion helper
> (HmdMatrix34ToWebVRTransformMatrix).
> 
> Please take another look. Thanks!

Rebase to ToT.

@bajones, @billorr, please take another look. Thanks!

[bajones, 2017-04-19 17:22:43]

On 2017/04/19 02:27:27, nhu wrote:
> On 2017/04/18 01:39:58, nhu wrote:
> > On 2017/04/17 18:09:43, bajones wrote:
> > > LGTM as well, though I agree with Bill that the Matrix conversion should
be
> a
> > > helper function.
> > 
> > I've updated it with matrix conversion helper
> > (HmdMatrix34ToWebVRTransformMatrix).
> > 
> > Please take another look. Thanks!
> 
> Rebase to ToT.
> 
> @bajones, @billorr, please take another look. Thanks!

LGTM again. I'll hit the commit button for you.

[bajones, 2017-04-19 17:22:47]

The CQ bit was checked by bajones@chromium.org

[bajones, 2017-04-19 17:22:48]

The patchset sent to the CQ was uploaded after l-g-t-m from billorr@chromium.org
Link to the patchset: https://codereview.chromium.org/2822983002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-19 17:23:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492622567785600,
"parent_rev": "28e11150e03e8d2bd8064fe1fa206e647c1b0030", "commit_rev":
"4774072a7a9b4b64adb17234eaadc922d1409439"}

[commit-bot: I haz the power, 2017-04-19 17:35:46]

Description was changed from

==========
Implement displayName and stageParameters of VRDisplay for OpenVRDevice

BUG=712181
==========

to

==========
Implement displayName and stageParameters of VRDisplay for OpenVRDevice

BUG=712181

Review-Url: https://codereview.chromium.org/2822983002
Cr-Commit-Position: refs/heads/master@{#465657}
Committed:
https://chromium.googlesource.com/chromium/src/+/4774072a7a9b4b64adb17234eaad...
==========

[commit-bot: I haz the power, 2017-04-19 17:35:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4774072a7a9b4b64adb17234eaad...