Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 282293005: Remove the setshape whitelist from the implementation. (Closed)

Created:
6 years, 7 months ago by garykac
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove the setshape whitelist from the implementation. This API is controlled by the app.window.shape permission which has its own whitelist, so there's no need to duplicate in the SetShape implementation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
garykac
6 years, 7 months ago (2014-05-22 18:44:53 UTC) #1
not at google - send to devlin
lgtm, sweet. can you remove the BUG or give it a valid BUG? is there ...
6 years, 7 months ago (2014-05-22 20:40:16 UTC) #2
garykac
The CQ bit was checked by garykac@chromium.org
6 years, 6 months ago (2014-06-02 16:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/282293005/1
6 years, 6 months ago (2014-06-02 16:32:32 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 19:26:43 UTC) #5
Message was sent while issue was closed.
Change committed as 274303

Powered by Google App Engine
This is Rietveld 408576698