Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

Issue 282293005: Remove the setshape whitelist from the implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
index ff2c2aa1c891eec13d3c41a25606ca20a150a956..78ca0bc6c682abe743ea8ec828f959cab7833148 100644
--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
@@ -45,9 +45,6 @@ const char kNoAssociatedAppWindow[] =
const char kDevChannelOnly[] =
"This function is currently only available in the Dev channel.";
-const char kBetaChannelOnly[] =
- "This function is currently only available in the Beta or Dev channel.";
-
const char kRequiresFramelessWindow[] =
"This function requires a frameless window (frame:none).";
@@ -353,49 +350,6 @@ bool AppCurrentWindowInternalSetShapeFunction::RunWithWindow(
return false;
}
- const char* whitelist[] = {
- "0F42756099D914A026DADFA182871C015735DD95", // http://crbug.com/323773
- "2D22CDB6583FD0A13758AEBE8B15E45208B4E9A7",
-
- "E7E2461CE072DF036CF9592740196159E2D7C089", // http://crbug.com/356200
- "A74A4D44C7CFCD8844830E6140C8D763E12DD8F3",
- "312745D9BF916161191143F6490085EEA0434997",
- "53041A2FA309EECED01FFC751E7399186E860B2C",
-
- "EBA908206905323CECE6DC4B276A58A0F4AC573F",
- "2775E568AC98F9578791F1EAB65A1BF5F8CEF414",
- "4AA3C5D69A4AECBD236CAD7884502209F0F5C169",
- "E410CDAB2C6E6DD408D731016CECF2444000A912",
- "9E930B2B5EABA6243AE6C710F126E54688E8FAF6",
-
- "FAFE8EFDD2D6AE2EEB277AFEB91C870C79064D9E", // http://crbug.com/327507
- "3B52D273A271D4E2348233E322426DBAE854B567",
- "5DF6ADC8708DF59FCFDDBF16AFBFB451380C2059",
- "1037DEF5F6B06EA46153AD87B6C5C37440E3F2D1",
- "F5815DAFEB8C53B078DD1853B2059E087C42F139",
- "6A08EFFF9C16E090D6DCC7EC55A01CADAE840513",
-
- "C32D6D93E12F5401DAA3A723E0C3CC5F25429BA4", // http://crbug.com/354258
- "9099782647D39C778E15C8C6E0D23C88F5CDE170",
- "B7D5B52D1E5B106288BD7F278CAFA5E8D76108B0",
- "89349DBAA2C4022FB244AA50182AB60934EB41EE",
- "CB593E510640572A995CB1B6D41BD85ED51E63F8",
- "1AD1AC86C87969CD3434FA08D99DBA6840AEA612",
- "9C2EA21D7975BDF2B3C01C3A454EE44854067A6D",
- "D2C488C80C3C90C3E01A991112A05E37831E17D0",
- "6EEC061C0E74B46C7B5BE2EEFA49436368F4988F",
- "8B344D9E8A4C505EF82A0DBBC25B8BD1F984E777",
- "E06AFCB1EB0EFD237824CC4AC8FDD3D43E8BC868"
- };
- if (GetCurrentChannel() > chrome::VersionInfo::CHANNEL_BETA &&
- !SimpleFeature::IsIdInList(
- GetExtension()->id(),
- std::set<std::string>(whitelist,
- whitelist + arraysize(whitelist)))) {
- error_ = kBetaChannelOnly;
- return false;
- }
-
scoped_ptr<SetShape::Params> params(
SetShape::Params::Create(*args_));
const Region& shape = params->region;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698