|
|
Description[Media Router] Clarifying context for string 'Dial Device Description Parser'
For b/37234823
BUG=711841
Review-Url: https://codereview.chromium.org/2822843003
Cr-Commit-Position: refs/heads/master@{#465676}
Committed: https://chromium.googlesource.com/chromium/src/+/28695cd0fcce0beddcaa7b02d224d63c7bf9f7a5
Patch Set 1 #
Total comments: 2
Patch Set 2 : resolve code review comments from Derek #
Total comments: 1
Messages
Total messages: 19 (11 generated)
Description was changed from ========== [Media Router] Clarifying context for string 'Dial Device Description Parser' For CL/37234823 BUG= ========== to ========== [Media Router] Clarifying context for string 'Dial Device Description Parser' For b/37234823 BUG=711841 ==========
zhaobin@chromium.org changed reviewers: + srahim@chromium.org
The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
zhaobin@chromium.org changed reviewers: + imcheng@chromium.org, mfoltz@chromium.org
lgtm
https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:3505: <message name="IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME" desc="The name of the utility process used for parsing the XML file that contains descriptions of devices."> Suggestion: ... parsing XML of uPnP device descriptions of DIAL devices.
lgtm after comment addressed.
https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:3505: <message name="IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME" desc="The name of the utility process used for parsing the XML file that contains descriptions of devices."> On 2017/04/18 20:34:26, imcheng wrote: > Suggestion: > > ... parsing XML of uPnP device descriptions of DIAL devices. Done.
The CQ bit was checked by zhaobin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org, imcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2822843003/#ps20001 (title: "resolve code review comments from Derek")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492623055103480, "parent_rev": "00d22da8fba8b6620cb2df2fc388bb6d096674e9", "commit_rev": "28695cd0fcce0beddcaa7b02d224d63c7bf9f7a5"}
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Clarifying context for string 'Dial Device Description Parser' For b/37234823 BUG=711841 ========== to ========== [Media Router] Clarifying context for string 'Dial Device Description Parser' For b/37234823 BUG=711841 Review-Url: https://codereview.chromium.org/2822843003 Cr-Commit-Position: refs/heads/master@{#465676} Committed: https://chromium.googlesource.com/chromium/src/+/28695cd0fcce0beddcaa7b02d224... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/28695cd0fcce0beddcaa7b02d224...
Message was sent while issue was closed.
https://codereview.chromium.org/2822843003/diff/20001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2822843003/diff/20001/chrome/app/generated_re... chrome/app/generated_resources.grd:3505: <message name="IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME" desc="The name of the utility process used for parsing XML of uPnP device descriptions of DIAL devices."> Please clarify further: What does "uPnP" mean? Add a sentence: DIAL stands for DIscovery And Launch. Do not translate DIAL. |