Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2822843003: [Media Router] Clarifying context for string 'Dial Device Description Parser' (Closed)

Created:
3 years, 8 months ago by zhaobin
Modified:
3 years, 8 months ago
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Clarifying context for string 'Dial Device Description Parser' For b/37234823 BUG=711841 Review-Url: https://codereview.chromium.org/2822843003 Cr-Commit-Position: refs/heads/master@{#465676} Committed: https://chromium.googlesource.com/chromium/src/+/28695cd0fcce0beddcaa7b02d224d63c7bf9f7a5

Patch Set 1 #

Total comments: 2

Patch Set 2 : resolve code review comments from Derek #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 19 (11 generated)
zhaobin
3 years, 8 months ago (2017-04-15 01:07:45 UTC) #7
srahim
lgtm
3 years, 8 months ago (2017-04-18 20:22:23 UTC) #9
imcheng
https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resources.grd#newcode3505 chrome/app/generated_resources.grd:3505: <message name="IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME" desc="The name of the utility process used ...
3 years, 8 months ago (2017-04-18 20:34:26 UTC) #10
imcheng
lgtm after comment addressed.
3 years, 8 months ago (2017-04-18 20:34:53 UTC) #11
zhaobin
https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2822843003/diff/1/chrome/app/generated_resources.grd#newcode3505 chrome/app/generated_resources.grd:3505: <message name="IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME" desc="The name of the utility process used ...
3 years, 8 months ago (2017-04-18 20:45:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822843003/20001
3 years, 8 months ago (2017-04-19 17:31:43 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/28695cd0fcce0beddcaa7b02d224d63c7bf9f7a5
3 years, 8 months ago (2017-04-19 18:25:05 UTC) #18
srahim
3 years, 8 months ago (2017-04-25 02:10:31 UTC) #19
Message was sent while issue was closed.
https://codereview.chromium.org/2822843003/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2822843003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:3505: <message
name="IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME" desc="The name of
the utility process used for parsing XML of uPnP device descriptions of DIAL
devices.">
Please clarify further: 
What does "uPnP" mean?
Add a sentence: DIAL stands for DIscovery And Launch. Do not translate DIAL.

Powered by Google App Engine
This is Rietveld 408576698