Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2822813002: [Home] Disable home button (Closed)

Created:
3 years, 8 months ago by mdjones
Modified:
3 years, 8 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Disable home button The home button is being replaced by a tile in the most visited section of the suggestions page. This change prevents the home icon from appearing in the toolbar when Chrome Home is enabled. BUG=703994 Review-Url: https://codereview.chromium.org/2822813002 Cr-Commit-Position: refs/heads/master@{#464938} Committed: https://chromium.googlesource.com/chromium/src/+/38691774fb2d6ce0f7850b8d6f4a7511e5ae220f

Patch Set 1 #

Patch Set 2 : add whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mdjones
ptal
3 years, 8 months ago (2017-04-14 22:19:23 UTC) #2
Theresa
lgtm
3 years, 8 months ago (2017-04-14 22:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822813002/20001
3 years, 8 months ago (2017-04-17 16:41:08 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 17:19:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38691774fb2d6ce0f7850b8d6f4a...

Powered by Google App Engine
This is Rietveld 408576698