Only access the genius app in Google-branded builds

Only access the genius app in Google-branded builds

ShowHelpImpl incorrectly used the OFFICIAL_BUILD flag for a feature
that should only be in Google-branded builds.

The app is only whitelisted by IsComponentExtensionWhitelisted when
GOOGLE_CHROME_BUILD is set, so this mismatch would cause a crash in
ChromiumOS builds.

BUG=none
TEST=Build browser with is_official_build=true and target_os=chromeos. Click the help button in the system menu, verify it does not crash.

Review-Url: https://codereview.chromium.org/2822793002
Cr-Commit-Position: refs/heads/master@{#464839}
Committed: https://chromium.googlesource.com/chromium/src/+/260b89ab85b12c863d2d9c1b4c995dfddf8b199c

[nicholasbishop, 2017-04-14 21:49:50]

nbishop@neverware.com changed reviewers:
+ msw@chromium.org

[msw, 2017-04-14 22:16:49]

lgtm

[nicholasbishop, 2017-04-15 00:02:01]

The CQ bit was checked by nbishop@neverware.com

[commit-bot: I haz the power, 2017-04-15 00:02:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 00:46:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492214521949480, "parent_rev":
"a13a008cf0c9dda19e6f3953e01c2492e02fff6f", "commit_rev":
"260b89ab85b12c863d2d9c1b4c995dfddf8b199c"}

[commit-bot: I haz the power, 2017-04-15 00:48:08]

Description was changed from

==========
Only access the genius app in Google-branded builds

ShowHelpImpl incorrectly used the OFFICIAL_BUILD flag for a feature
that should only be in Google-branded builds.

The app is only whitelisted by IsComponentExtensionWhitelisted when
GOOGLE_CHROME_BUILD is set, so this mismatch would cause a crash in
ChromiumOS builds.

BUG=none
TEST=Build browser with is_official_build=true and target_os=chromeos. Click the
help button in the system menu, verify it does not crash.
==========

to

==========
Only access the genius app in Google-branded builds

ShowHelpImpl incorrectly used the OFFICIAL_BUILD flag for a feature
that should only be in Google-branded builds.

The app is only whitelisted by IsComponentExtensionWhitelisted when
GOOGLE_CHROME_BUILD is set, so this mismatch would cause a crash in
ChromiumOS builds.

BUG=none
TEST=Build browser with is_official_build=true and target_os=chromeos. Click the
help button in the system menu, verify it does not crash.

Review-Url: https://codereview.chromium.org/2822793002
Cr-Commit-Position: refs/heads/master@{#464839}
Committed:
https://chromium.googlesource.com/chromium/src/+/260b89ab85b12c863d2d9c1b4c99...
==========

[commit-bot: I haz the power, 2017-04-15 00:48:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/260b89ab85b12c863d2d9c1b4c99...