Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2822783002:
[Cleanup] Clean up enum ordering code in extract_histograms.py (Closed)
|
Created:
3 years, 8 months ago by Ilya Sherman Modified:
3 years, 8 months ago Reviewers:
DmitrySkiba CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Cleanup] Clean up enum ordering code in extract_histograms.py
This is a small follow-up to https://codereview.chromium.org/2810733005/
BUG=none
R=dskiba@chromium.org
Review-Url: https://codereview.chromium.org/2822783002
Cr-Commit-Position: refs/heads/master@{#464834}
Committed: https://chromium.googlesource.com/chromium/src/+/28e7e0c728a13f214322c336d3957644302a5f20
Patch Set 1 #Patch Set 2 : Whitespace #
Total comments: 2
Patch Set 3 : Log just the string label #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2822783002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/extract_histograms.py (right): https://codereview.chromium.org/2822783002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/extract_histograms.py:235: int_value, left_int_value, left_label) Previously it was logging just a string, but now left_label is actually a dict - is this intentional?
https://codereview.chromium.org/2822783002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/extract_histograms.py (right): https://codereview.chromium.org/2822783002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/extract_histograms.py:235: int_value, left_int_value, left_label) On 2017/04/14 22:01:41, DmitrySkiba wrote: > Previously it was logging just a string, but now left_label is actually a dict - > is this intentional? Whoops, not intentional, thanks. Fixed.
The CQ bit was checked by isherman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by isherman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492213919596860,
"parent_rev": "9e27be00af394259afe4fd40b0c5955a29b29c40", "commit_rev":
"28e7e0c728a13f214322c336d3957644302a5f20"}
Message was sent while issue was closed.
Description was changed from ========== [Cleanup] Clean up enum ordering code in extract_histograms.py This is a small follow-up to https://codereview.chromium.org/2810733005/ BUG=none R=dskiba@chromium.org ========== to ========== [Cleanup] Clean up enum ordering code in extract_histograms.py This is a small follow-up to https://codereview.chromium.org/2810733005/ BUG=none R=dskiba@chromium.org Review-Url: https://codereview.chromium.org/2822783002 Cr-Commit-Position: refs/heads/master@{#464834} Committed: https://chromium.googlesource.com/chromium/src/+/28e7e0c728a13f214322c336d395... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/28e7e0c728a13f214322c336d395... |
