chrome/browser/resources/settings/people_page/setup_pin_dialog.html - Issue 2822733002: md settings: Small changes to lock screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Issue 2822733002: md settings: Small changes to lock screen. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/people_page/password_prompt_dialog.js ('K') | « chrome/browser/resources/settings/people_page/password_prompt_dialog.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

index 040c5cbc932ba25c5920f9ee7f196d66a5b87ddf..805c66035ad3df8e5d57010774051ec00ff59ca2 100644

--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

@@ -30,6 +30,12 @@

#pinKeyboardDiv {

justify-content: center;

}

+ /* Use this instead of hidden or dom-if so that the dialog does not resize

+ when the problem appears or disappears. */

+ #problemDiv[invisible] {

+ visibility: hidden;

+ }

stevenjb 2017/04/14 21:47:20 A simpler approach might just be to hide the iron-

sammiequon 2017/04/14 22:11:43 Done.

</style>

<dialog is="cr-dialog" id="dialog" on-close="close"

@@ -39,7 +45,7 @@

<!-- Warning/error; only shown if title is hidden. Id is needed for

tests. -->

<div id="problemDiv" class$="[[problemClass_]] settings-box first"

- hidden$="[[!hasProblem_(problemMessage_)]]">

+ invisible$="[[!hasProblem_(problemMessage_)]]">

<iron-icon icon="settings:warning"></iron-icon>

<span class="middle">[[problemMessage_]]</span>

</div>