md settings: Small changes to lock screen.

chrome/browser/resources/settings/people_page/setup_pin_dialog.html

 <link rel="import" href="chrome://resources/html/assert.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="../i18n_setup.html">
 <link rel="import" href="../icons.html">
 <link rel="import" href="lock_screen_constants.html">
 <link rel="import" href="pin_keyboard.html">
 <link rel="import" href="../settings_shared_css.html">
 
@@ skipping 12 matching lines @@
         color: var(--paper-red-500);
       }
 
       .error > iron-icon {
         --iron-icon-fill-color: var(--paper-red-500);
       }
 
       #pinKeyboardDiv {
         justify-content: center;
       }
+
+      /* Use this instead of hidden or dom-if so that the dialog does not resize
+         when the problem appears or disappears. */
+      #problemDiv[invisible] {
+        visibility: hidden;
+      }

[stevenjb, 2017/04/14 21:47:20]

A simpler approach might just be to hide the iron-icon with
hidden-[[!problemMessage]]. (I don't think you need hasProblem_)

[sammiequon, 2017/04/14 22:11:43]

Done.

     </style>
 
     <dialog is="cr-dialog" id="dialog" on-close="close"
         close-text="$i18n{close}">
       <div class="title">[[getTitleMessage_(isConfirmStep_)]]</div>
       <div class="body">
         <!-- Warning/error; only shown if title is hidden. Id is needed for
              tests. -->
         <div id="problemDiv" class$="[[problemClass_]] settings-box first"
-             hidden$="[[!hasProblem_(problemMessage_)]]">
+            invisible$="[[!hasProblem_(problemMessage_)]]">
           <iron-icon icon="settings:warning"></iron-icon>
           <span class="middle">[[problemMessage_]]</span>
         </div>
 
         <!-- Pin keyboard -->
         <div id="pinKeyboardDiv" class="settings-box continuation">
           <pin-keyboard id="pinKeyboard" on-pin-change="onPinChange_"
               on-submit="onPinSubmit_" value="{{pinKeyboardValue_}}">
           </pin-keyboard>
         </div>
 
         <div class="button-strip">
           <paper-button class="cancel-button" on-tap="onCancelTap_">
             $i18n{cancel}
           </paper-button>
 
           <paper-button class="action-button" on-tap="onPinSubmit_"
               disabled$="[[!enableSubmit_]]">
             <span>[[getContinueMessage_(isConfirmStep_)]]</span>
           </paper-button>
         </div>
       </div>
     </dialog>
   </template>
 
   <script src="setup_pin_dialog.js"></script>
 </dom-module>