Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2822663003: Make Submit button on user pods unfocusable (Closed)

Created:
3 years, 8 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 8 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Submit button on user pods unfocusable Submit button receives unnecessary focus when password field is empty, but becomes unfocusable after user enters password. This CL makes it unfocusable all the time. BUG=706794 Review-Url: https://codereview.chromium.org/2822663003 Cr-Commit-Position: refs/heads/master@{#464981} Committed: https://chromium.googlesource.com/chromium/src/+/9152c28bf002c0f0d270a951b81d92a7a413c055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/login/account_picker/user_pod_row.js View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Wenzhao (Colin) Zang
3 years, 8 months ago (2017-04-14 19:47:44 UTC) #4
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-04-17 19:19:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822663003/1
3 years, 8 months ago (2017-04-17 19:20:27 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 19:33:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9152c28bf002c0f0d270a951b81d...

Powered by Google App Engine
This is Rietveld 408576698