Issue 282263007: Fix bindings when using [CachedAttribute] on Array.

Issue 282263007: Fix bindings when using [CachedAttribute] on Array. (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 7 months ago

Reviewers:
Nils Barth (inactive), haraken

CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, blink-reviews-bindings_chromium.org, haraken, Nate Chapin

Base URL:
https://chromium.googlesource.com/chromium/blink.git@language_change_tests

Visibility:
Public.

More Reviews

Description

Fix bindings when using [CachedAttribute] on Array. This make sure we call the proper cpp_value_to_v8_value instead of doing {cpp_value}.v8value() which doesn't work for all types. BUG=374146 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174161

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -3 lines)			Patch
M	Source/bindings/scripts/v8_attributes.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/templates/attributes.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/idls/TestObject.idl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View		4 chunks	+43 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM. https://codereview.chromium.org/282263007/diff/1/Source/bindings/scripts/v8_attributes.py File Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/282263007/diff/1/Source/bindings/scripts/v8_attributes.py#newcode204 Source/bindings/scripts/v8_attributes.py:204: # We need to override cpp_value_to_v8_value to make ...

6 years, 7 months ago (2014-05-16 11:06:22 UTC) #2

mlamouri (slow - plz ping)

On 2014/05/16 11:06:22, haraken wrote: > LGTM. > > https://codereview.chromium.org/282263007/diff/1/Source/bindings/scripts/v8_attributes.py > File Source/bindings/scripts/v8_attributes.py (right): > ...

6 years, 7 months ago (2014-05-16 11:10:33 UTC) #3

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 7 months ago (2014-05-16 11:10:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/282263007/20001

6 years, 7 months ago (2014-05-16 11:10:57 UTC) #5

Message was sent while issue was closed.

Change committed as 174161

Expand Messages | Collapse Messages