Source/bindings/templates/attributes.cpp - Issue 282263007: Fix bindings when using [CachedAttribute] on Array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 282263007: Fix bindings when using [CachedAttribute] on Array. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@language_change_tests

Patch Set: review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index 8fa9ec315935210da2bbee2f2e6338b2ba3ad101..04e41b4380b04e6655f7dece973c70d509427c9c 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -95,7 +95,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info

}

{% endif %}

{% if attribute.cached_attribute_validation_method %}

- V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, propertyName, {{attribute.cpp_value}}.v8Value());

+ V8HiddenValue::setHiddenValue(info.GetIsolate(), holder, propertyName, {{attribute.cpp_value_to_v8_value}});

{% endif %}

{# v8SetReturnValue #}

{% if attribute.is_keep_alive_for_gc %}

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »