Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2822613004: [M58] ash: Do not constrain window bounds if requested (Closed)

Created:
3 years, 8 months ago by Dominik Laskowski
Modified:
3 years, 8 months ago
Reviewers:
oshima, reveman
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[M58] ash: Do not constrain window bounds if requested If a client requests to set window bounds directly, Ash should not interfere, e.g. by constraining them to the workspace size. ARC windows are maximized to the display rather than the workspace. However, Ash would constrain the ShellSurface bounds to the workspace size. As a result, if the shelf was positioned to the left, the right edge of the window would be displaced from that of the display by the width of the shelf, so the app was unresponsive to input in that gap. TBR=oshima@chromium.org,reveman@chromium.org NOTRY=true NOPRESUBMIT=true BUG=709616 TEST=Print window hierarchy using debug shortcut, and verify that the bounds of a maximized ShellSurface match the display bounds. Review-Url: https://codereview.chromium.org/2822613004 Cr-Commit-Position: refs/branch-heads/3029@{#716} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d901345e2c36527bc5f4ab8f8237cd92d4766e22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M ash/common/wm/default_state.cc View 6 chunks +6 lines, -3 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/common/wm/window_state.h View 2 chunks +5 lines, -8 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/exo/shell_surface.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822613004/1
3 years, 8 months ago (2017-04-14 18:42:19 UTC) #2
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 18:48:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d901345e2c36527bc5f4ab8f8237...

Powered by Google App Engine
This is Rietveld 408576698