Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2822613003: When updating expectations during wpt import, fill in results from missing builds. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

When updating expectations during wpt import, fill in results from missing builds. In the latest build, wpt import failed because android_blink_rel failed: https://chromium-review.googlesource.com/c/477675/ This turns on the --fill-missing flag in webkit-patch rebaseline-cl, which will make it so that in the future when results can't be fetched for some build, results from another build are used. Review-Url: https://codereview.chromium.org/2822613003 Cr-Commit-Position: refs/heads/master@{#464808} Committed: https://chromium.googlesource.com/chromium/src/+/e5ff978c98c235da0dfb6f6d8dc45f5e0c764eec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
qyearsley
3 years, 8 months ago (2017-04-14 15:31:39 UTC) #3
jeffcarp
lgtm
3 years, 8 months ago (2017-04-14 21:14:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822613003/1
3 years, 8 months ago (2017-04-14 21:16:50 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 22:26:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5ff978c98c235da0dfb6f6d8dc4...

Powered by Google App Engine
This is Rietveld 408576698