cc: Create raster tasks in AssignGpuMemoryToTiles.

cc: Create raster tasks in AssignGpuMemoryToTiles.

Currently the raster task creation is done in
TileManager::ScheduleTasks, which is after all the prioritized work has
been created in AssignGpuMemoryToTiles.

In order to align the prioritization of images decoded by the
CheckerImageTracker, we need to create a decode queue for images
decoded by the tracker as we iterate through the tiles in raster
priority order. This is done in AssignGpuMemoryToTiles.

In the case of checker-imaged tiles, we don't need to add them to
tiles_to_raster since they have a valid resource. But we do need to
decode images currently being checkered on them. Since the priorities
for checker-imaged tiles and tiles requiring raster are interleaved, the
analysis for images and building of the decode queue needs to be done
during the iteration for all tiles.

This change moves raster task creation, where the image analysis is
performed, from ScheduleTasks to AssignGpuMemoryToTiles. Since
ScheduleTasks only iterates through tiles_to_raster while
AssignGpuMemoryToTiles will iterate through both, tiles requiring raster
and checker-imaged tiles.

BUG=689184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2822493003
Cr-Commit-Position: refs/heads/master@{#464792}
Committed: https://chromium.googlesource.com/chromium/src/+/757e34b1e982b37a0333c87b3cd4184bd712c5b5

[Khushal, 2017-04-14 02:31:16]

Description was changed from

==========
cc: Create raster tasks in AssignGpuMemoryToTiles.

Currently the raster task creation is done in
TileManager::ScheduleTasks, which is after all the prioritized work has
been created in AssignGpuMemoryToTiles.

In order to align the prioritization of images decoded by the
CheckerImageTracker, we need to create a decode queue for images
decoded by the tracker as we iterate through the tiles in raster
priority order. This is done in AssignGpuMemoryToTiles.

In the case of checker-imaged tiles, we don't need to add them to
tiles_to_raster since they have a valid resource. But we do need to
decode images currently being checkered on them. Since the priorities
for checker-imaged tiles and tiles requiring raster are interleaved, the
analysis for images and building of the decode queue needs to be done
during the iteration for all tiles.

This change moves raster task creation, where the image analysis is
performed, from ScheduleTasks to AssignGpuMemoryToTiles. Since
ScheduleTasks only iterates through tiles_to_raster while
AssignGpuMemoryToTiles will iterate through both, tiles requiring raster
and checker-imaged tiles.

BUG=689184
==========

to

==========
cc: Create raster tasks in AssignGpuMemoryToTiles.

Currently the raster task creation is done in
TileManager::ScheduleTasks, which is after all the prioritized work has
been created in AssignGpuMemoryToTiles.

In order to align the prioritization of images decoded by the
CheckerImageTracker, we need to create a decode queue for images
decoded by the tracker as we iterate through the tiles in raster
priority order. This is done in AssignGpuMemoryToTiles.

In the case of checker-imaged tiles, we don't need to add them to
tiles_to_raster since they have a valid resource. But we do need to
decode images currently being checkered on them. Since the priorities
for checker-imaged tiles and tiles requiring raster are interleaved, the
analysis for images and building of the decode queue needs to be done
during the iteration for all tiles.

This change moves raster task creation, where the image analysis is
performed, from ScheduleTasks to AssignGpuMemoryToTiles. Since
ScheduleTasks only iterates through tiles_to_raster while
AssignGpuMemoryToTiles will iterate through both, tiles requiring raster
and checker-imaged tiles.

BUG=689184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2017-04-14 02:31:53]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[Khushal, 2017-04-14 02:31:59]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 03:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 03:52:35]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2017-04-14 18:25:59]

lgtm

https://codereview.chromium.org/2822493003/diff/1/cc/tiles/tile_manager.cc
File cc/tiles/tile_manager.cc (right):

https://codereview.chromium.org/2822493003/diff/1/cc/tiles/tile_manager.cc#ne...
cc/tiles/tile_manager.cc:946: TRACE_EVENT0("cc",
"TileManager::CreateRasterTask");
Can you make this disabled by default cc.debug?

[Khushal, 2017-04-14 19:11:34]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-04-14 19:11:34]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2822493003/#ps20001
(title: "disabled-by-default")

[commit-bot: I haz the power, 2017-04-14 19:12:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 20:59:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492197094094580,
"parent_rev": "14d5464e149236d40c40fe015ab10848f5a36d8d", "commit_rev":
"757e34b1e982b37a0333c87b3cd4184bd712c5b5"}

[commit-bot: I haz the power, 2017-04-14 21:00:02]

Description was changed from

==========
cc: Create raster tasks in AssignGpuMemoryToTiles.

Currently the raster task creation is done in
TileManager::ScheduleTasks, which is after all the prioritized work has
been created in AssignGpuMemoryToTiles.

In order to align the prioritization of images decoded by the
CheckerImageTracker, we need to create a decode queue for images
decoded by the tracker as we iterate through the tiles in raster
priority order. This is done in AssignGpuMemoryToTiles.

In the case of checker-imaged tiles, we don't need to add them to
tiles_to_raster since they have a valid resource. But we do need to
decode images currently being checkered on them. Since the priorities
for checker-imaged tiles and tiles requiring raster are interleaved, the
analysis for images and building of the decode queue needs to be done
during the iteration for all tiles.

This change moves raster task creation, where the image analysis is
performed, from ScheduleTasks to AssignGpuMemoryToTiles. Since
ScheduleTasks only iterates through tiles_to_raster while
AssignGpuMemoryToTiles will iterate through both, tiles requiring raster
and checker-imaged tiles.

BUG=689184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Create raster tasks in AssignGpuMemoryToTiles.

Currently the raster task creation is done in
TileManager::ScheduleTasks, which is after all the prioritized work has
been created in AssignGpuMemoryToTiles.

In order to align the prioritization of images decoded by the
CheckerImageTracker, we need to create a decode queue for images
decoded by the tracker as we iterate through the tiles in raster
priority order. This is done in AssignGpuMemoryToTiles.

In the case of checker-imaged tiles, we don't need to add them to
tiles_to_raster since they have a valid resource. But we do need to
decode images currently being checkered on them. Since the priorities
for checker-imaged tiles and tiles requiring raster are interleaved, the
analysis for images and building of the decode queue needs to be done
during the iteration for all tiles.

This change moves raster task creation, where the image analysis is
performed, from ScheduleTasks to AssignGpuMemoryToTiles. Since
ScheduleTasks only iterates through tiles_to_raster while
AssignGpuMemoryToTiles will iterate through both, tiles requiring raster
and checker-imaged tiles.

BUG=689184
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2822493003
Cr-Commit-Position: refs/heads/master@{#464792}
Committed:
https://chromium.googlesource.com/chromium/src/+/757e34b1e982b37a0333c87b3cd4...
==========

[commit-bot: I haz the power, 2017-04-14 21:00:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/757e34b1e982b37a0333c87b3cd4...