Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2822473002: Add GetPostData and ID to headless::Request plus fix GetFrameTreeNodeId (Closed)

Created:
3 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a helper to retrieve any PostData. Also adds a unique request ID. Finally fixes GetFrameTreeNodeId for browser initiated fetches. BUG=546953 Review-Url: https://codereview.chromium.org/2822473002 Cr-Commit-Position: refs/heads/master@{#465298} Committed: https://chromium.googlesource.com/chromium/src/+/74500bd4d32d826311be745333f5b338b68bf63b

Patch Set 1 #

Patch Set 2 : Various fixes #

Patch Set 3 : Add a test for GetPostData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -19 lines) Patch
M headless/public/util/generic_url_request_job.h View 1 4 chunks +9 lines, -0 lines 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 9 chunks +42 lines, -14 lines 0 comments Download
M headless/public/util/generic_url_request_job_test.cc View 1 2 5 chunks +70 lines, -4 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (16 generated)
alex clarke (OOO till 29th)
PTAL
3 years, 8 months ago (2017-04-13 15:22:40 UTC) #3
Sami
lgtm
3 years, 8 months ago (2017-04-18 18:09:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822473002/40001
3 years, 8 months ago (2017-04-18 18:34:32 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 18:46:13 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/74500bd4d32d826311be745333f5...

Powered by Google App Engine
This is Rietveld 408576698