Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp

Issue 2822453003: Wrap large IndexedDB values into Blobs before writing to LevelDB. (Closed)
Patch Set: Fixed compilation errors on Windows and no-DCHECKs. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp b/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
index 2f7f7df7a69c68efc6b1941849c1c97745086bfd..16b7c5a9fa293ecf532eae9d95e77c2982f573fc 100644
--- a/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
@@ -78,7 +78,7 @@ void WebIDBCallbacksImpl::OnError(const WebIDBDatabaseError& error) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "error");
- request_->OnError(DOMException::Create(error.Code(), error.Message()));
+ request_->QueueResult(DOMException::Create(error.Code(), error.Message()));
}
void WebIDBCallbacksImpl::OnSuccess(
@@ -101,8 +101,8 @@ void WebIDBCallbacksImpl::OnSuccess(WebIDBCursor* cursor,
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(WTF::WrapUnique(cursor), key, primary_key,
- IDBValue::Create(value, request_->GetIsolate()));
+ request_->QueueResult(WTF::WrapUnique(cursor), key, primary_key,
+ IDBValue::Create(value, request_->GetIsolate()));
}
void WebIDBCallbacksImpl::OnSuccess(WebIDBDatabase* backend,
@@ -122,7 +122,7 @@ void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(key);
+ request_->QueueResult(key);
}
void WebIDBCallbacksImpl::OnSuccess(const WebIDBValue& value) {
@@ -130,7 +130,7 @@ void WebIDBCallbacksImpl::OnSuccess(const WebIDBValue& value) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(IDBValue::Create(value, request_->GetIsolate()));
+ request_->QueueResult(IDBValue::Create(value, request_->GetIsolate()));
}
void WebIDBCallbacksImpl::OnSuccess(const WebVector<WebIDBValue>& values) {
@@ -141,7 +141,7 @@ void WebIDBCallbacksImpl::OnSuccess(const WebVector<WebIDBValue>& values) {
Vector<RefPtr<IDBValue>> idb_values(values.size());
for (size_t i = 0; i < values.size(); ++i)
idb_values[i] = IDBValue::Create(values[i], request_->GetIsolate());
- request_->OnSuccess(idb_values);
+ request_->QueueResult(idb_values);
}
void WebIDBCallbacksImpl::OnSuccess(long long value) {
@@ -167,8 +167,8 @@ void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key,
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(key, primary_key,
- IDBValue::Create(value, request_->GetIsolate()));
+ request_->QueueResult(key, primary_key,
+ IDBValue::Create(value, request_->GetIsolate()));
}
void WebIDBCallbacksImpl::OnBlocked(long long old_version) {

Powered by Google App Engine
This is Rietveld 408576698