Wrap large IndexedDB values into Blobs before writing to LevelDB.

third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 60 matching lines @@
     probe::AsyncTaskCanceled(request_->GetExecutionContext(), this);
     request_->WebCallbacksDestroyed();
   }
 }
 
 void WebIDBCallbacksImpl::OnError(const WebIDBDatabaseError& error) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "error");
-  request_->OnError(DOMException::Create(error.Code(), error.Message()));
+  request_->QueueResult(DOMException::Create(error.Code(), error.Message()));
 }
 
 void WebIDBCallbacksImpl::OnSuccess(
     const WebVector<WebString>& web_string_list) {
   if (!request_)
     return;
 
   Vector<String> string_list;
   for (size_t i = 0; i < web_string_list.size(); ++i)
     string_list.push_back(web_string_list[i]);
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
   request_->OnSuccess(string_list);

[dmurph, 2017/05/04 22:27:07]

Can you dcheck that we don't have any queued results on the request?

[pwnall, 2017/05/11 23:54:24]

Done.

 }
 
 void WebIDBCallbacksImpl::OnSuccess(WebIDBCursor* cursor,
                                     const WebIDBKey& key,
                                     const WebIDBKey& primary_key,
                                     const WebIDBValue& value) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
-  request_->OnSuccess(WTF::WrapUnique(cursor), key, primary_key,
-                      IDBValue::Create(value, request_->GetIsolate()));
+  request_->QueueResult(WTF::WrapUnique(cursor), key, primary_key,
+                        IDBValue::Create(value, request_->GetIsolate()));
 }
 
 void WebIDBCallbacksImpl::OnSuccess(WebIDBDatabase* backend,
                                     const WebIDBMetadata& metadata) {
   std::unique_ptr<WebIDBDatabase> db = WTF::WrapUnique(backend);
   if (request_) {
     probe::AsyncTask async_task(request_->GetExecutionContext(), this,
                                 "success");
     request_->OnSuccess(std::move(db), IDBDatabaseMetadata(metadata));
   } else if (db) {
     db->Close();
   }

[dmurph, 2017/05/04 22:27:07]

Can you dcheck that we don't have any queued results on the request?

[pwnall, 2017/05/11 23:54:24]

Done.

 }
 
 void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
-  request_->OnSuccess(key);
+  request_->QueueResult(key);
 }
 
 void WebIDBCallbacksImpl::OnSuccess(const WebIDBValue& value) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
-  request_->OnSuccess(IDBValue::Create(value, request_->GetIsolate()));
+  request_->QueueResult(IDBValue::Create(value, request_->GetIsolate()));
 }
 
 void WebIDBCallbacksImpl::OnSuccess(const WebVector<WebIDBValue>& values) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
   Vector<RefPtr<IDBValue>> idb_values(values.size());
   for (size_t i = 0; i < values.size(); ++i)
     idb_values[i] = IDBValue::Create(values[i], request_->GetIsolate());
-  request_->OnSuccess(idb_values);
+  request_->QueueResult(idb_values);
 }
 
 void WebIDBCallbacksImpl::OnSuccess(long long value) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
   request_->OnSuccess(value);

[dmurph, 2017/05/04 22:27:07]

Can you dcheck that we don't have any queued results on the request?

[pwnall, 2017/05/11 23:54:24]

Per jsbell's comment, this one's actually going through the queue right now.

 }
 
 void WebIDBCallbacksImpl::OnSuccess() {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
   request_->OnSuccess();

[dmurph, 2017/05/04 22:27:07]

Can you dcheck that we don't have any queued results on the request?

[pwnall, 2017/05/11 23:54:25]

Per jsbell's comment, this one's actually going through the queue right now.

 }
 
 void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key,
                                     const WebIDBKey& primary_key,
                                     const WebIDBValue& value) {
   if (!request_)
     return;
 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
-  request_->OnSuccess(key, primary_key,
-                      IDBValue::Create(value, request_->GetIsolate()));
+  request_->QueueResult(key, primary_key,
+                        IDBValue::Create(value, request_->GetIsolate()));
 }
 
 void WebIDBCallbacksImpl::OnBlocked(long long old_version) {
   if (!request_)
     return;

[dmurph, 2017/05/04 22:27:07]

Can you dcheck that we don't have any queued results on the request?

[pwnall, 2017/05/11 23:54:24]

Done.

 
   probe::AsyncTask async_task(request_->GetExecutionContext(), this, "blocked");
   request_->OnBlocked(old_version);
 }
 
 void WebIDBCallbacksImpl::OnUpgradeNeeded(long long old_version,
                                           WebIDBDatabase* database,
                                           const WebIDBMetadata& metadata,
                                           unsigned short data_loss,
                                           WebString data_loss_message) {
   std::unique_ptr<WebIDBDatabase> db = WTF::WrapUnique(database);

[dmurph, 2017/05/04 22:27:07]

Can you dcheck that we don't have any queued results on the request?

[pwnall, 2017/05/11 23:54:24]

Done.

   if (request_) {
     probe::AsyncTask async_task(request_->GetExecutionContext(), this,
                                 "upgradeNeeded");
     request_->OnUpgradeNeeded(
         old_version, std::move(db), IDBDatabaseMetadata(metadata),
         static_cast<WebIDBDataLoss>(data_loss), data_loss_message);
   } else {
     db->Close();
   }
 }
 
 void WebIDBCallbacksImpl::Detach() {
   request_.Clear();
 }
 
 }  // namespace blink