Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2822453002:
Display the first item for list mac native notifications (Closed)
|
Created:
3 years, 8 months ago by Miguel Garcia Modified:
3 years, 8 months ago Reviewers:
Peter Beverloo CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisplay the first item for list mac native notifications
BUG=
Review-Url: https://codereview.chromium.org/2822453002
Cr-Commit-Position: refs/heads/master@{#464874}
Committed: https://chromium.googlesource.com/chromium/src/+/c226012b866b916e187030737404c6ed6ccfe15a
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
miguelg@chromium.org changed reviewers: + peter@chromium.org
Barebones changes so that we can cherry pick in the branch if we agree this is the right call. I will follow up with a test (and perhaps move it to a method) if so.
lgtm https://codereview.chromium.org/2822453002/diff/1/chrome/browser/notification... File chrome/browser/notifications/notification_platform_bridge_mac.mm (right): https://codereview.chromium.org/2822453002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_mac.mm:190: notification.items().at(0).message); You could improve RTL support by using a simple structure like the following: base::string16 CreateNotificationMessage(const Notification& notification) { if (notification.items().empty()) return notification.message(); const message_center::NotificationItem& item = notification.items()[0]; const base::string16 separator = base::UTF8ToUTF16(" - "); if (base::i18n::IsRTL()) return item.message + separator + item.title; return item.title + separator + item.message; }
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by miguelg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by miguelg@chromium.org
The CQ bit was checked by miguelg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org Link to the patchset: https://codereview.chromium.org/2822453002/#ps20001 (title: "rebase")
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org Link to the patchset: https://codereview.chromium.org/2822453002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492284001136980,
"parent_rev": "aadb33c433f1cf2eb17e4862215c9857c7e26dd1", "commit_rev":
"c226012b866b916e187030737404c6ed6ccfe15a"}
Message was sent while issue was closed.
Description was changed from ========== Display the first item for list mac native notifications BUG= ========== to ========== Display the first item for list mac native notifications BUG= Review-Url: https://codereview.chromium.org/2822453002 Cr-Commit-Position: refs/heads/master@{#464874} Committed: https://chromium.googlesource.com/chromium/src/+/c226012b866b916e187030737404... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c226012b866b916e187030737404... |
