Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2822433004: Remove audio_loop cases from tough_video_cases pagesets. (Closed)

Created:
3 years, 8 months ago by CalebRouleau
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, sullivan, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove audio_loop cases from tough_video_cases pagesets. The only thing they measured was avg_loop_time. These tests are no longer needed since we have seek time metrics and time_to_play metrics now. This should reduce the benchmark_duration of media.tough_media_cases_extra by 140ms * 50 loops * 2 pages = 14 seconds. A followup Catapult CL should remove now-unused code such as https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/actions/loop.py Design doc: https://docs.google.com/document/d/1TvUWPl6diK3DTJdSWMOcdz-6qnKC6KEHAZqoBBD8lIc/edit# BUG=710253 Review-Url: https://codereview.chromium.org/2822433004 Cr-Commit-Position: refs/heads/master@{#464629} Committed: https://chromium.googlesource.com/chromium/src/+/e6f79e605ba482c827e07f30378eb5a61a43a677

Patch Set 1 #

Patch Set 2 : Also remove html page and media file sha1s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -69 lines) Patch
M tools/perf/page_sets/tough_video_cases.py View 1 6 chunks +3 lines, -44 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/audio_playback.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D tools/perf/page_sets/tough_video_cases/pink_noise_140ms.wav.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/tough_video_cases/pink_noise_20s.wav.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
CalebRouleau
PTAL
3 years, 8 months ago (2017-04-13 21:41:26 UTC) #5
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-13 21:45:35 UTC) #6
johnchen
LGTM
3 years, 8 months ago (2017-04-13 22:22:05 UTC) #7
nednguyen
LGTM
3 years, 8 months ago (2017-04-13 22:25:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822433004/20001
3 years, 8 months ago (2017-04-13 22:33:29 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:46:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6f79e605ba482c827e07f30378e...

Powered by Google App Engine
This is Rietveld 408576698