Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2822353003: Simplify RFI::CreateMediaPlayer (Closed)

Created:
3 years, 8 months ago by tguilbert
Modified:
3 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify RFI::CreateMediaPlayer Since CourierRendererFactory (used to be called AdaptiveRendererFactory) no longer takes a RendererFactory as a construction parameter, we can clean up the logic in RFI::CreateMediaPlayer, so that is is simpler to read. BUG=663503 Review-Url: https://codereview.chromium.org/2822353003 Cr-Commit-Position: refs/heads/master@{#470129} Committed: https://chromium.googlesource.com/chromium/src/+/9affbc15342e08bc0162756c9d1ec32fdf492fab

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : SetBaseFactoryType #

Patch Set 4 : Fix build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -38 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 4 chunks +28 lines, -38 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (12 generated)
tguilbert
PTAL! This is the last CL in the series of CLs following the introduction of ...
3 years, 7 months ago (2017-05-03 21:56:37 UTC) #5
ncarter (slow)
https://codereview.chromium.org/2822353003/diff/60001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/2822353003/diff/60001/content/renderer/render_frame_impl.cc#oldcode2978 content/renderer/render_frame_impl.cc:2978: factory_selector->SetBaseFactoryType(factory_type); Is it no longer necessary to call SetBaseFactoryType?
3 years, 7 months ago (2017-05-03 23:25:32 UTC) #6
tguilbert
https://codereview.chromium.org/2822353003/diff/60001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/2822353003/diff/60001/content/renderer/render_frame_impl.cc#oldcode2978 content/renderer/render_frame_impl.cc:2978: factory_selector->SetBaseFactoryType(factory_type); On 2017/05/03 23:25:32, ncarter wrote: > Is it ...
3 years, 7 months ago (2017-05-03 23:29:05 UTC) #7
ncarter (slow)
lgtm
3 years, 7 months ago (2017-05-04 22:22:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822353003/100001
3 years, 7 months ago (2017-05-05 18:49:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/286838)
3 years, 7 months ago (2017-05-05 21:43:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822353003/100001
3 years, 7 months ago (2017-05-05 22:16:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/287132)
3 years, 7 months ago (2017-05-06 01:39:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822353003/100001
3 years, 7 months ago (2017-05-08 19:45:45 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:17:23 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9affbc15342e08bc0162756c9d1e...

Powered by Google App Engine
This is Rietveld 408576698