Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2822343002: [Android] Rename package_name in java_cpp_template to package_path. (Closed)

Created:
3 years, 8 months ago by jbudorick
Modified:
3 years, 8 months ago
Reviewers:
mdjones, agrieve, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, danakj+watch_chromium.org, net-reviews_chromium.org, zpeng+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Rename package_name in java_cpp_template to package_path. I'm working on a change that will require android_apk clients to pass the actual package name (e.g. "org.chromium.base") to support a java_cpp_template client that requires the package name. This CL should prevent confusion or suboptimal names. BUG=710811 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2822343002 Cr-Commit-Position: refs/heads/master@{#466015} Committed: https://chromium.googlesource.com/chromium/src/+/1e5e1dcfccdb9ec8625bda61a0afda98bf05ffb1

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M base/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/config/android/rules.gni View 6 chunks +14 lines, -5 lines 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/libs/client/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
jbudorick
3 years, 8 months ago (2017-04-18 23:24:19 UTC) #5
agrieve
On 2017/04/18 23:24:19, jbudorick wrote: lgtm
3 years, 8 months ago (2017-04-19 00:20:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822343002/1
3 years, 8 months ago (2017-04-19 00:30:00 UTC) #10
jbudorick
+mdjones for dom_distiller +xunjieli for cronet and net
3 years, 8 months ago (2017-04-19 00:34:45 UTC) #13
xunjieli
On 2017/04/19 00:34:45, jbudorick wrote: > +mdjones for dom_distiller > +xunjieli for cronet and net ...
3 years, 8 months ago (2017-04-19 15:13:47 UTC) #14
mdjones
dom_distiller/ lgtm
3 years, 8 months ago (2017-04-19 15:30:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822343002/20001
3 years, 8 months ago (2017-04-20 14:11:52 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:25:13 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e5e1dcfccdb9ec8625bda61a0af...

Powered by Google App Engine
This is Rietveld 408576698