Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2822313002: Re-enable AccessibilityObjectModel tests by setting the status to "test". (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
tkent, foolip
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, kinuko+watch, dmazzoni
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable AccessibilityObjectModel tests by setting the status to "test". By setting the status of the feature in RuntimeEnabledFeatures.json5 to "test" instead of "experimental", it's automatically enabled in tests. Previously when the mode was set to "experimental", it was being disabled by the content feature. If this is a reasonable fix, should we update the documentation at the top of RuntimeEnabledFeatures.json5 to say that "test" can be used for features that are controlled by a content flag but should be enabled for tests? BUG=712332 Review-Url: https://codereview.chromium.org/2822313002 Cr-Commit-Position: refs/heads/master@{#465539} Committed: https://chromium.googlesource.com/chromium/src/+/1c58631e4fa8074280e1ba81d639db80fcd5df3c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update one more expectation #

Messages

Total messages: 18 (13 generated)
dmazzoni
3 years, 8 months ago (2017-04-18 21:55:58 UTC) #4
tkent
lgtm if test failures are resolved. > If this is a reasonable fix, should we ...
3 years, 8 months ago (2017-04-18 23:10:01 UTC) #5
tkent
> Previously when the mode was set to "experimental", it was being disabled > by ...
3 years, 8 months ago (2017-04-18 23:17:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822313002/40001
3 years, 8 months ago (2017-04-19 07:34:42 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 09:26:47 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1c58631e4fa8074280e1ba81d639...

Powered by Google App Engine
This is Rietveld 408576698