Format all files under the sdk/lib directory.

Format all files under the sdk/lib directory.

BUG=
R=floitsch@google.com, terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/c890c487fe92fb96a2f56b20d7d00c58f571406d

[Jacob, 2017-04-18 20:25:38]

jacobr@google.com changed reviewers:
+ terry@google.com

[Jacob, 2017-04-18 20:27:28]

Description was changed from

==========
Format all files under the sdk/lib directory.

BUG=
==========

to

==========
Format all files under the sdk/lib directory.

BUG=
==========

[Jacob, 2017-04-18 20:27:28]

jacobr@google.com changed reviewers:
+ floitsch@google.com

[terry, 2017-04-18 21:27:39]

lgtm

[floitsch, 2017-04-19 09:34:20]

LGTM with comments.
These looks similar to another CL I reviewed. What happened to that one?

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/convert/base64....
File sdk/lib/convert/base64.dart (right):

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/convert/base64....
sdk/lib/convert/base64.dart:518: __,
Please don't explode alphabet lists that have been aligned to be 16 elements per
line.

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/core/uri.dart#n...
sdk/lib/core/uri.dart:2852: //             LSB            MSB
These comments must stay aligned.

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/core/uri.dart#n...
sdk/lib/core/uri.dart:3691: //             LSB             MSB
These comments must stay aligned.

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/internal/intern...
File sdk/lib/internal/internal.dart (right):

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/internal/intern...
sdk/lib/internal/internal.dart:24: /*  0 */
These comments are on the wrong line.

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart#...
sdk/lib/io/crypto.dart:25: -2,
These tables should stay aligned.

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart#...
sdk/lib/io/crypto.dart:563: 0xd76aa478,
Should (probably) stay aligned, although it's just an MD5 table.
Would probably be ok this way, although it now takes 6 times as many lines as
before.

https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart#...
sdk/lib/io/crypto.dart:630: 7,
ditto.

[Jacob, 2017-04-19 15:12:51]

On 2017/04/19 09:34:20, floitsch wrote:
> LGTM with comments.
> These looks similar to another CL I reviewed. What happened to that one?
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/convert/base64....
> File sdk/lib/convert/base64.dart (right):
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/convert/base64....
> sdk/lib/convert/base64.dart:518: __,
> Please don't explode alphabet lists that have been aligned to be 16 elements
per
> line.
> 
> https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/core/uri.dart
> File sdk/lib/core/uri.dart (right):
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/core/uri.dart#n...
> sdk/lib/core/uri.dart:2852: //             LSB            MSB
> These comments must stay aligned.
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/core/uri.dart#n...
> sdk/lib/core/uri.dart:3691: //             LSB             MSB
> These comments must stay aligned.
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/internal/intern...
> File sdk/lib/internal/internal.dart (right):
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/internal/intern...
> sdk/lib/internal/internal.dart:24: /*  0 */
> These comments are on the wrong line.
> 
> https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart
> File sdk/lib/io/crypto.dart (right):
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart#...
> sdk/lib/io/crypto.dart:25: -2,
> These tables should stay aligned.
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart#...
> sdk/lib/io/crypto.dart:563: 0xd76aa478,
> Should (probably) stay aligned, although it's just an MD5 table.
> Would probably be ok this way, although it now takes 6 times as many lines as
> before.
> 
>
https://codereview.chromium.org/2822303002/diff/20001/sdk/lib/io/crypto.dart#...
> sdk/lib/io/crypto.dart:630: 7,
> ditto.

You are correct. I found the one CL I'd missed committing and landed that
instead for the files requiring tweaks before formatter output was reasonable.

[Jacob, 2017-04-19 15:16:26]

Description was changed from

==========
Format all files under the sdk/lib directory.

BUG=
==========

to

==========
Format all files under the sdk/lib directory.

BUG=
R=floitsch@google.com, terry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c890c487fe92fb96a2f56b20d7d00c58f571406d
==========

[Jacob, 2017-04-19 15:16:27]

Committed patchset #3 (id:40001) manually as
c890c487fe92fb96a2f56b20d7d00c58f571406d (presubmit successful).