Remove PaintCanvas::writePixels

Remove PaintCanvas::writePixels

This method doesn't make a lot of sense when building a recording, and
it is not used for recordings for that reason. This changes callers of
it to call it on the SkSurface's SkCanvas directly instead by moving the
calls into Un/AcceleratedImageBufferSurface.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2822263004
Cr-Commit-Position: refs/heads/master@{#465805}
Committed: https://chromium.googlesource.com/chromium/src/+/6527e1ef5c38b22789f94f5ae4c763031f5932f7

[danakj, 2017-04-18 23:42:36]

Description was changed from

==========
rm-writepixels

R=enne@chromium.org, junov@chromium.org
BUG=671433
==========

to

==========
rm-writepixels

R=enne@chromium.org, junov@chromium.org
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-04-18 23:42:38]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 23:43:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 23:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:48:20]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[danakj, 2017-04-19 20:36:01]

Patchset #1 (id:1) has been deleted

[danakj, 2017-04-19 20:36:05]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 20:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-19 20:38:44]

Description was changed from

==========
rm-writepixels

R=enne@chromium.org, junov@chromium.org
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove PaintCanvas::writePixels

This method doesn't make a lot of sense when building a recording, and
it is not used for recordings for that reason. This changes callers of
it to call it on the SkSurface's SkCanvas directly instead by moving the
calls into Un/AcceleratedImageBufferSurface.

R=enne@chromium.org, junov@chromium.org
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-04-19 20:55:58]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 20:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-19 20:56:26]

Description was changed from

==========
Remove PaintCanvas::writePixels

This method doesn't make a lot of sense when building a recording, and
it is not used for recordings for that reason. This changes callers of
it to call it on the SkSurface's SkCanvas directly instead by moving the
calls into Un/AcceleratedImageBufferSurface.

R=enne@chromium.org, junov@chromium.org
BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove PaintCanvas::writePixels

This method doesn't make a lot of sense when building a recording, and
it is not used for recordings for that reason. This changes callers of
it to call it on the SkSurface's SkCanvas directly instead by moving the
calls into Un/AcceleratedImageBufferSurface.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-04-19 20:56:37]

danakj@chromium.org changed reviewers:
+ xlai@chromium.org
- junov@chromium.org

[danakj, 2017-04-19 20:59:15]

danakj@chromium.org changed reviewers:
+ pdr@chromium.org

[danakj, 2017-04-19 20:59:15]

+pdr for webkit owners stamp if xlai approves

[enne (OOO), 2017-04-19 21:00:42]

Yay! lgtm

[xlai (Olivia), 2017-04-19 21:13:41]

lgtm with nits

https://codereview.chromium.org/2822263004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
(right):

https://codereview.chromium.org/2822263004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp:81:
return surface_->getCanvas()->writePixels(orig_info, pixels, row_bytes, x, y);
You put a DCHECK(surface_) in AcceleratedImageBufferSurface. Why don't you do
the same here as well?

[danakj, 2017-04-19 21:19:05]

https://codereview.chromium.org/2822263004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
(right):

https://codereview.chromium.org/2822263004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp:81:
return surface_->getCanvas()->writePixels(orig_info, pixels, row_bytes, x, y);
On 2017/04/19 21:13:41, xlai (Olivia) wrote:
> You put a DCHECK(surface_) in AcceleratedImageBufferSurface. Why don't you do
> the same here as well?

Oh, I cargoculted that TBH it shouldn't matter in either case, we'd crash
somewhere when we writepixels somewhere. I'll remove so less LOC.

[danakj, 2017-04-19 21:20:05]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 21:20:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-19 21:42:30]

pdr: PTAL for owners

[pdr., 2017-04-19 21:49:48]

On 2017/04/19 at 21:42:30, danakj wrote:
> pdr: PTAL for owners

LGTM

[danakj, 2017-04-19 21:58:12]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-04-19 21:58:18]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-04-19 21:58:19]

The patchset sent to the CQ was uploaded after l-g-t-m from xlai@chromium.org,
enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2822263004/#ps60001
(title: "rm-writepixels: rmdcheck")

[commit-bot: I haz the power, 2017-04-19 21:59:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:23:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492639098568480,
"parent_rev": "431d50287a50b50bbc65b9074ce6044405879a95", "commit_rev":
"6527e1ef5c38b22789f94f5ae4c763031f5932f7"}

[commit-bot: I haz the power, 2017-04-19 23:23:56]

Description was changed from

==========
Remove PaintCanvas::writePixels

This method doesn't make a lot of sense when building a recording, and
it is not used for recordings for that reason. This changes callers of
it to call it on the SkSurface's SkCanvas directly instead by moving the
calls into Un/AcceleratedImageBufferSurface.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove PaintCanvas::writePixels

This method doesn't make a lot of sense when building a recording, and
it is not used for recordings for that reason. This changes callers of
it to call it on the SkSurface's SkCanvas directly instead by moving the
calls into Un/AcceleratedImageBufferSurface.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2822263004
Cr-Commit-Position: refs/heads/master@{#465805}
Committed:
https://chromium.googlesource.com/chromium/src/+/6527e1ef5c38b22789f94f5ae4c7...
==========

[commit-bot: I haz the power, 2017-04-19 23:23:58]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6527e1ef5c38b22789f94f5ae4c7...