Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2822253006: Added a bulletpoint about autofill data to the Incognito NTP (Closed)

Created:
3 years, 8 months ago by msramek
Modified:
3 years, 8 months ago
Reviewers:
srahim, sdefresne
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a bulletpoint about autofill data to the Incognito NTP TBR=sdefresne@chromium.org BUG=693525 Review-Url: https://codereview.chromium.org/2822253006 Cr-Commit-Position: refs/heads/master@{#465952} Committed: https://chromium.googlesource.com/chromium/src/+/e7cf9f66afb5f63cee9465a8b4056d7ca7edd853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/new_or_sad_tab_strings.grdp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
msramek
Hi Shimi! As we discussed, this CL adds a third bulletpoint to the Incognito NTP, ...
3 years, 8 months ago (2017-04-19 08:52:19 UTC) #2
srahim
On 2017/04/19 08:52:19, msramek wrote: > Hi Shimi! > > As we discussed, this CL ...
3 years, 8 months ago (2017-04-19 19:29:35 UTC) #3
msramek
Thanks, Shimi! +Sylvain, since this is a non-structural string change, and I again have a ...
3 years, 8 months ago (2017-04-20 08:25:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822253006/1
3 years, 8 months ago (2017-04-20 08:25:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e7cf9f66afb5f63cee9465a8b4056d7ca7edd853
3 years, 8 months ago (2017-04-20 08:38:20 UTC) #11
sdefresne
3 years, 8 months ago (2017-04-20 09:27:20 UTC) #12
Message was sent while issue was closed.
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698