Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2822233004: ppapi: Include <netinet/in.h> for sockaddr_in{6}. (Closed)

Created:
3 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 8 months ago
Reviewers:
bbudge, raymes
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: Include <netinet/in.h> for sockaddr_in{6}. IWYU and stop pulling sockaddr_in/sockaddr_in6's definitions indirectly. R=bbudge@chromium.org,raymes@chromium.org Review-Url: https://codereview.chromium.org/2822233004 Cr-Commit-Position: refs/heads/master@{#465937} Committed: https://chromium.googlesource.com/chromium/src/+/6d8144380c92106e1d4454cad45057d4b544c9ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ppapi/shared_impl/private/net_address_private_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Raphael Kubo da Costa (rakuco)
PTAL
3 years, 8 months ago (2017-04-19 10:19:25 UTC) #2
raymes
lgtm
3 years, 8 months ago (2017-04-19 23:17:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822233004/1
3 years, 8 months ago (2017-04-20 07:34:36 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 07:39:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d8144380c92106e1d4454cad450...

Powered by Google App Engine
This is Rietveld 408576698