Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2822233003: gfx: Remove Canvas::ExtractImageRep. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, enne (OOO)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gfx: Remove Canvas::ExtractImageRep. This method does a pixel copy which is expensive and unnesseary for recording. There are no callers of this method left so we can remove it. R=pkasting@chromium.org BUG=671433 Review-Url: https://codereview.chromium.org/2822233003 Cr-Commit-Position: refs/heads/master@{#465321} Committed: https://chromium.googlesource.com/chromium/src/+/166e5eede3378cc08466dae28da82845393ee2a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ui/gfx/canvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
danakj
3 years, 8 months ago (2017-04-18 17:33:16 UTC) #3
Peter Kasting
LGTM!
3 years, 8 months ago (2017-04-18 18:50:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822233003/1
3 years, 8 months ago (2017-04-18 19:11:32 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:19:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/166e5eede3378cc08466dae28da8...

Powered by Google App Engine
This is Rietveld 408576698