Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2822193003: [wasm] Enable local iframe test. (Closed)

Created:
3 years, 8 months ago by Mircea Trofin
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm] Enable local iframe test. It appears the original reason this bug was disabled does not reproduce anymore; also fixed unrelated test bug (it's unrelated to the original reason the test was disabled, because, originally, instantiation wasn't working full stop because of differences in contexts. Test bug just wasn't receiving data correctly.) BUG=chromium:700788 Review-Url: https://codereview.chromium.org/2822193003 Cr-Commit-Position: refs/heads/master@{#465610} Committed: https://chromium.googlesource.com/chromium/src/+/16aa23bd2b41c31151e42d612f10d683defaa5f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/wasm/resources/frame.html View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/wasm/wasm_local_iframe_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Mircea Trofin
3 years, 8 months ago (2017-04-18 23:01:16 UTC) #7
bradn
lgtm
3 years, 8 months ago (2017-04-19 04:53:21 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-19 10:18:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822193003/1
3 years, 8 months ago (2017-04-19 15:13:07 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:17:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16aa23bd2b41c31151e42d612f10...

Powered by Google App Engine
This is Rietveld 408576698