Warn when adding something to a closed sink and improve documentation

Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted: https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
Committed: https://github.com/dart-lang/sdk/commit/c0090fa01fe59b7982891b8c4e34ed4cabd2296f
Reverted: https://github.com/dart-lang/sdk/commit/a4eb8b8fe36f2a8de24a265b63de164719d66517
Committed: https://github.com/dart-lang/sdk/commit/5202df2238f8585da8a0ea31995acef1a3a59ac2

[floitsch, 2017-04-18 13:29:07]

floitsch@google.com changed reviewers:
+ lrn@google.com

[floitsch, 2017-04-19 16:17:44]

Description was changed from

==========
Throw when adding something to a closed sink.
==========

to

==========
Throw when adding something to a closed sink.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

[floitsch, 2017-04-19 16:19:16]

Description was changed from

==========
Throw when adding something to a closed sink.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

[floitsch, 2017-04-19 16:19:56]

Incorporated documentation changes fixing issue 29122.

[floitsch, 2017-04-25 17:34:11]

ping.

[Lasse Reichstein Nielsen, 2017-04-26 08:26:20]

lgtm

https://codereview.chromium.org/2822173002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2822173002/diff/20001/CHANGELOG.md#newcode15
CHANGELOG.md:15: * Adding to a closed sink now throws.
Also updates dart:core's Sink, so add `dart:core` as well.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1466: * A [Sink] that supports adding errors and
closing.
The [Sink] already supports closing, so it's redundant to mention here, so just
"... that supports adding errors."

Perhaps also say that this makes it suitable for capturing the results of
asynchronous *computations* (which can complete with a value *or* an error).

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1468: abstract class EventSink<T> implements Sink<T> {
The name "EventSink" comes from streams, so I'm not sure removing the reference
to streams in the documentation is really necessary.
If it is, maybe we should rename this sink to AsyncSink (which we won't because
it's breaking, but still!).
So, make some sort of documentation about what an "event" is in the class
documentation, because it's needed as context for the name (and the "event" uses
below).

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1470: * Puts a data [event] into the sink.
Puts .. into -> Adds .. to

We generally use "add" about what we do to sinks.
Dittos below.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1481: void addError(Object errorEvent, [StackTrace
stackTrace]);
Hmm, errorEvent -> error.
It's suspicious that the error is an event and the stackTrace isn't. And it's
not clear what event is (unless you write it somewhere, in which case you
probably don't need to repeat it here anyway).

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1486: * No further events can be added after closing.
Can you close more than once?

What is an event? (that should be documented in the class doc, as stated above).

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_co...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_co...
sdk/lib/async/stream_controller.dart:240: * Listeners receive this event at a
later microtask. This behavior can be
at -> in (or as). 
A microtask has a duration, it's not a point in time, so I don't think "at"
applies - but that's obviously a subjective idea :)

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_co...
sdk/lib/async/stream_controller.dart:241: * overridden by using `sync`
controllers. Note, however, that sync
Overridden means something else (you override a method), so it's somewhat
confusing to use it here with a different meaning - even if it's technically
correct.

How about:

Note that a synchronous controller (created by passing true for the `sync`
parameter of the `StreamController` constructor) delivers events immediately, so
they must be used as described in the documentation of the constructor to ensure
that the delivered events always *appear* to be in a separate microtask.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_tr...
File sdk/lib/async/stream_transformers.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_tr...
sdk/lib/async/stream_transformers.dart:212: final EventSink<T> _sink;
Make this field non-final and set it to null when you close.
Then change _isClosed to 
  bool get _isClosed => _sink == null;

That saves one field.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_tr...
sdk/lib/async/stream_transformers.dart:236: void close() {
We should probably bail out here if the sink is already closed.
So:
  if (_isClosed) return;

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/core/sink.dart
File sdk/lib/core/sink.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/core/sink.dart#...
sdk/lib/core/sink.dart:17: * Puts the [data] into the sink.
Change Puts-into into Adds-to. Or maybe "Pass-to"

It's a silly documentation anyway - it just repeats the method name, but I guess
that's the cost of being completely generic.

[floitsch, 2017-05-01 16:46:25]

https://codereview.chromium.org/2822173002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2822173002/diff/20001/CHANGELOG.md#newcode15
CHANGELOG.md:15: * Adding to a closed sink now throws.
On 2017/04/26 08:26:18, Lasse Reichstein Nielsen wrote:
> Also updates dart:core's Sink, so add `dart:core` as well.

Done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1466: * A [Sink] that supports adding errors and
closing.
On 2017/04/26 08:26:18, Lasse Reichstein Nielsen wrote:
> The [Sink] already supports closing, so it's redundant to mention here, so
just
> "... that supports adding errors."
> 
> Perhaps also say that this makes it suitable for capturing the results of
> asynchronous *computations* (which can complete with a value *or* an error).
> 
> 
> 

Done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1468: abstract class EventSink<T> implements Sink<T> {
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> The name "EventSink" comes from streams, so I'm not sure removing the
reference
> to streams in the documentation is really necessary.
> If it is, maybe we should rename this sink to AsyncSink (which we won't
because
> it's breaking, but still!).
> So, make some sort of documentation about what an "event" is in the class
> documentation, because it's needed as context for the name (and the "event"
uses
> below).

Added a paragraph:
 * The [EventSink] has been designed to handle asynchronous events from
 * [Stream]s. See, for example, [Stream.eventTransformed] which uses
 * `EventSink`s to transform events.

I agree, that the name is not great, but I don't think we should change the name
to `AsyncSink`. That's a misnomer as well.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1470: * Puts a data [event] into the sink.
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> Puts .. into -> Adds .. to
> 
> We generally use "add" about what we do to sinks.
> Dittos below.
> 

Done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1481: void addError(Object errorEvent, [StackTrace
stackTrace]);
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> Hmm, errorEvent -> error.
> It's suspicious that the error is an event and the stackTrace isn't. And it's
> not clear what event is (unless you write it somewhere, in which case you
> probably don't need to repeat it here anyway).

Done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1486: * No further events can be added after closing.
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> Can you close more than once?
> 
> What is an event? (that should be documented in the class doc, as stated
above).

   * Calling this method more than once is allowed, but does nothing.
   *
   * Neither [add] nor [addError] must be called after this method.

done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_co...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_co...
sdk/lib/async/stream_controller.dart:240: * Listeners receive this event at a
later microtask. This behavior can be
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> at -> in (or as). 
> A microtask has a duration, it's not a point in time, so I don't think "at"
> applies - but that's obviously a subjective idea :)

Done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_co...
sdk/lib/async/stream_controller.dart:241: * overridden by using `sync`
controllers. Note, however, that sync
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> Overridden means something else (you override a method), so it's somewhat
> confusing to use it here with a different meaning - even if it's technically
> correct.
> 
> How about:
> 
> Note that a synchronous controller (created by passing true for the `sync`
> parameter of the `StreamController` constructor) delivers events immediately,
so
> they must be used as described in the documentation of the constructor to
ensure
> that the delivered events always *appear* to be in a separate microtask.

   * Note that a synchronous controller (created by passing true to the `sync`
   * parameter of the `StreamController` constructor) delivers events
   * immediately. Since this behavior violates the contract mentioned here,
   * synchronous controllers should only be used as described in the
   * documentation to ensure that the delivered events always *appear* as if
   * they were delivered in a separate microtask.

done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_tr...
File sdk/lib/async/stream_transformers.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_tr...
sdk/lib/async/stream_transformers.dart:212: final EventSink<T> _sink;
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> Make this field non-final and set it to null when you close.
> Then change _isClosed to 
>   bool get _isClosed => _sink == null;
> 
> That saves one field.

Done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/async/stream_tr...
sdk/lib/async/stream_transformers.dart:236: void close() {
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> We should probably bail out here if the sink is already closed.
> So:
>   if (_isClosed) return;

Realized the same thing.
done.

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/core/sink.dart
File sdk/lib/core/sink.dart (right):

https://codereview.chromium.org/2822173002/diff/20001/sdk/lib/core/sink.dart#...
sdk/lib/core/sink.dart:17: * Puts the [data] into the sink.
On 2017/04/26 08:26:19, Lasse Reichstein Nielsen wrote:
> Change Puts-into into Adds-to. Or maybe "Pass-to"
> 
> It's a silly documentation anyway - it just repeats the method name, but I
guess
> that's the cost of being completely generic.

I'm ok with repeating the name, if there is more dartdoc.
done.

[floitsch, 2017-05-03 13:43:30]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

This reverts https://codereview.chromium.org/20036002.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

[floitsch, 2017-05-03 13:44:06]

floitsch@google.com changed reviewers:
+ whesse@google.com

[floitsch, 2017-05-03 13:44:06]

+whesse: I updated the documentation for SecureSocket.

[floitsch, 2017-05-03 13:44:43]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

This reverts https://codereview.chromium.org/20036002.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

[Bill Hesse, 2017-05-03 14:10:11]

lgtm

https://codereview.chromium.org/2822173002/diff/60001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2822173002/diff/60001/CHANGELOG.md#newcode18
CHANGELOG.md:18: * Adding to a closed sink now throws.
Could you also note that this applies to IOSinks like ...?

https://codereview.chromium.org/2822173002/diff/60001/sdk/lib/core/sink.dart
File sdk/lib/core/sink.dart (right):

https://codereview.chromium.org/2822173002/diff/60001/sdk/lib/core/sink.dart#...
sdk/lib/core/sink.dart:17: * Adds the [data] to the sink.
Maybe drop the word "the": Adds [data] to the sink.

[floitsch, 2017-05-03 18:28:08]

Thanks.

https://codereview.chromium.org/2822173002/diff/60001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2822173002/diff/60001/CHANGELOG.md#newcode18
CHANGELOG.md:18: * Adding to a closed sink now throws.
On 2017/05/03 14:10:10, Bill Hesse wrote:
> Could you also note that this applies to IOSinks like ...?

Done.

https://codereview.chromium.org/2822173002/diff/60001/sdk/lib/core/sink.dart
File sdk/lib/core/sink.dart (right):

https://codereview.chromium.org/2822173002/diff/60001/sdk/lib/core/sink.dart#...
sdk/lib/core/sink.dart:17: * Adds the [data] to the sink.
On 2017/05/03 14:10:10, Bill Hesse wrote:
> Maybe drop the word "the": Adds [data] to the sink.

Done.

[floitsch, 2017-05-04 09:42:28]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
==========

[floitsch, 2017-05-04 09:42:29]

Committed patchset #5 (id:80001) manually as
8e19729b8913c4225ef84e863193e36879947727 (presubmit successful).

[floitsch, 2017-05-04 11:30:19]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

[floitsch, 2017-05-04 11:30:39]

Had to revert, because of pub failing.
Investigating.

[floitsch, 2017-05-04 11:30:57]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also fixes issue 29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

[floitsch, 2017-05-04 11:31:08]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

As port of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

to

==========
Throw when adding something to a closed sink and improve documentation.

As part of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

[floitsch, 2017-05-04 14:21:32]

Description was changed from

==========
Throw when adding something to a closed sink and improve documentation.

As part of this CL all changes of https://codereview.chromium.org/20036002 are
reverted.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

to

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

[floitsch, 2017-05-04 14:21:48]

PTAL.

[Lasse Reichstein Nielsen, 2017-05-08 11:31:09]

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/async/stream_t...
File sdk/lib/async/stream_transformers.dart (right):

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/async/stream_t...
sdk/lib/async/stream_transformers.dart:227: Zone.ROOT.print("  See
http://dartbug.com/29554.");
Cascade?

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/async/stream_t...
sdk/lib/async/stream_transformers.dart:228: Zone.ROOT.print(StackTrace.current);
Consider returning here. Adding isn't useful. Ditto below.

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/io/io_sink.dart
File sdk/lib/io/io_sink.dart (right):

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/io/io_sink.dar...
sdk/lib/io/io_sink.dart:154: stderr.writeln(StackTrace.current);
I don't know enough about stderr to be sure this doesn't have a side-effect on
other uses of stderr. I'm guessing it doesn't, but let's ask someone who'd know.

[Lasse Reichstein Nielsen, 2017-05-08 11:31:10]

lgtm

[floitsch, 2017-05-08 12:22:39]

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/async/stream_t...
File sdk/lib/async/stream_transformers.dart (right):

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/async/stream_t...
sdk/lib/async/stream_transformers.dart:227: Zone.ROOT.print("  See
http://dartbug.com/29554.");
On 2017/05/08 11:31:08, Lasse Reichstein Nielsen wrote:
> Cascade?

Done.

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/async/stream_t...
sdk/lib/async/stream_transformers.dart:228: Zone.ROOT.print(StackTrace.current);
On 2017/05/08 11:31:08, Lasse Reichstein Nielsen wrote:
> Consider returning here. Adding isn't useful. Ditto below.

The whole point of the warning is to keep the old behavior.
In the future we will throw.

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/io/io_sink.dart
File sdk/lib/io/io_sink.dart (right):

https://codereview.chromium.org/2822173002/diff/100001/sdk/lib/io/io_sink.dar...
sdk/lib/io/io_sink.dart:154: stderr.writeln(StackTrace.current);
On 2017/05/08 11:31:08, Lasse Reichstein Nielsen wrote:
> I don't know enough about stderr to be sure this doesn't have a side-effect on
> other uses of stderr. I'm guessing it doesn't, but let's ask someone who'd
know.

It completely interferes with the user's stderr.
However, it's still less likely to break them, than if we threw.

[floitsch, 2017-05-08 12:27:11]

Description was changed from

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
==========

to

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
Committed:
https://github.com/dart-lang/sdk/commit/c0090fa01fe59b7982891b8c4e34ed4cabd2296f
==========

[floitsch, 2017-05-08 12:27:13]

Committed patchset #8 (id:140001) manually as
c0090fa01fe59b7982891b8c4e34ed4cabd2296f (presubmit successful).

[floitsch, 2017-05-08 13:20:05]

Description was changed from

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
Committed:
https://github.com/dart-lang/sdk/commit/c0090fa01fe59b7982891b8c4e34ed4cabd2296f
==========

to

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
Committed:
https://github.com/dart-lang/sdk/commit/c0090fa01fe59b7982891b8c4e34ed4cabd2296f
Reverted:
https://github.com/dart-lang/sdk/commit/a4eb8b8fe36f2a8de24a265b63de164719d66517
==========

[floitsch, 2017-05-08 13:51:59]

Needed to change Zone.ROOT.print(StackTrace.current) to call toString() on the
stack trace first.

Also needed to update the status file. The analyzer seems to get confused in
some tests.

[floitsch, 2017-05-08 13:52:24]

Description was changed from

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
Committed:
https://github.com/dart-lang/sdk/commit/c0090fa01fe59b7982891b8c4e34ed4cabd2296f
Reverted:
https://github.com/dart-lang/sdk/commit/a4eb8b8fe36f2a8de24a265b63de164719d66517
==========

to

==========
Warn when adding something to a closed sink and improve documentation.

Adding to a closed sink will throw once
https://codereview.chromium.org/2857393003/ is committed.

Also:
Fixes #29122.

BUG= http://dartbug.com/29122
R=lrn@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e19729b8913c4225ef84e863193e36879947727
Reverted:
https://github.com/dart-lang/sdk/commit/8f3ae7e7e13fad563a84227fa78c6e520d956566
Committed:
https://github.com/dart-lang/sdk/commit/c0090fa01fe59b7982891b8c4e34ed4cabd2296f
Reverted:
https://github.com/dart-lang/sdk/commit/a4eb8b8fe36f2a8de24a265b63de164719d66517
Committed:
https://github.com/dart-lang/sdk/commit/5202df2238f8585da8a0ea31995acef1a3a59ac2
==========

[floitsch, 2017-05-08 13:52:25]

Committed patchset #9 (id:160001) manually as
5202df2238f8585da8a0ea31995acef1a3a59ac2 (presubmit successful).