Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2822063002: Media: Reject negative initial video timestamps in FFmpegDemuxer. (Closed)

Created:
3 years, 8 months ago by sandersd (OOO until July 31)
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: Reject negative initial timestamps in FFmpegDemuxer. During recent changes, it became possible for the first video buffer timestamp in a stream to be negative. This change restores the invariant that video buffer timestampes are non-negative, by emitting a demuxer error in this case. BUG=710845 Review-Url: https://codereview.chromium.org/2822063002 Cr-Commit-Position: refs/heads/master@{#465678} Committed: https://chromium.googlesource.com/chromium/src/+/7ef29df1ba9940551cbe64afd833706799bf6034

Patch Set 1 #

Patch Set 2 : Refine failure condition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/filters/ffmpeg_demuxer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
sandersd (OOO until July 31)
3 years, 8 months ago (2017-04-18 23:55:28 UTC) #9
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-18 23:58:52 UTC) #10
DaleCurtis
Description needs some more work though.
3 years, 8 months ago (2017-04-18 23:59:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822063002/20001
3 years, 8 months ago (2017-04-19 18:24:58 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:31:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ef29df1ba9940551cbe64afd833...

Powered by Google App Engine
This is Rietveld 408576698