Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2822053002: Remove unused "Disable remote Alt-Svc" QUIC experiment code. (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov, Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused "Disable remote Alt-Svc" QUIC experiment code. Review-Url: https://codereview.chromium.org/2822053002 Cr-Commit-Position: refs/heads/master@{#465204} Committed: https://chromium.googlesource.com/chromium/src/+/f10a5147ffdb2afbd0e524f768b840bda2259fb8

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Rebase #

Patch Set 4 : network_session_configurator_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M chrome/browser/io_thread_unittest.cc View 1 2 3 2 chunks +0 lines, -22 lines 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 1 2 3 2 chunks +0 lines, -10 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 1 2 3 3 chunks +0 lines, -14 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Ryan Hamilton
bnc: PTAL. I believe we don't need this knob anymore sergeyu: jingle/OWNERS, please
3 years, 8 months ago (2017-04-18 00:19:55 UTC) #2
Sergey Ulanov
src/jingle LGTM
3 years, 8 months ago (2017-04-18 00:23:20 UTC) #3
Bence
LGTM. Thank you for the cleanup.
3 years, 8 months ago (2017-04-18 12:02:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822053002/60001
3 years, 8 months ago (2017-04-18 12:03:28 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 12:07:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f10a5147ffdb2afbd0e524f768b8...

Powered by Google App Engine
This is Rietveld 408576698