Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.

include/effects/SkMatrixConvolutionImageFilter.h

Index: include/effects/SkMatrixConvolutionImageFilter.h
diff --git a/include/effects/SkMatrixConvolutionImageFilter.h b/include/effects/SkMatrixConvolutionImageFilter.h
index ee1bfcf3d9853be4aca2d40799f0c1737786e577..7f026649989c1fba3e18c72f5361806999f69742 100644
--- a/include/effects/SkMatrixConvolutionImageFilter.h
+++ b/include/effects/SkMatrixConvolutionImageFilter.h
@@ -68,7 +68,16 @@ public:
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkMatrixConvolutionImageFilter)
 
 protected:
-    SkMatrixConvolutionImageFilter(SkReadBuffer& buffer);
+    SkMatrixConvolutionImageFilter(const SkISize& kernelSize,
+                                   const SkScalar* kernel,
+                                   SkScalar gain,
+                                   SkScalar bias,
+                                   const SkIPoint& kernelOffset,
+                                   TileMode tileMode,
+                                   bool convolveAlpha,
+                                   SkImageFilter* input = NULL,

[scroggo, 2014/05/15 14:56:42]

While we're moving this, I think having default parameters on a protected
constructor does not make any sense. The only place we should have a default
parameter (if anywhere) is on the public facing factory.

+                                   const CropRect* cropRect = NULL);
+    explicit SkMatrixConvolutionImageFilter(SkReadBuffer& buffer);
     virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
 
     virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
@@ -83,19 +92,6 @@ protected:
                              const SkIRect& bounds) const SK_OVERRIDE;
 #endif
 
-#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
-public:
-#endif
-    SkMatrixConvolutionImageFilter(const SkISize& kernelSize,
-                                   const SkScalar* kernel,
-                                   SkScalar gain,
-                                   SkScalar bias,
-                                   const SkIPoint& kernelOffset,
-                                   TileMode tileMode,
-                                   bool convolveAlpha,
-                                   SkImageFilter* input = NULL,
-                                   const CropRect* cropRect = NULL);
-
 private:
     SkISize   fKernelSize;
     SkScalar* fKernel;