Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.

include/effects/SkColorMatrixFilter.h

Index: include/effects/SkColorMatrixFilter.h
diff --git a/include/effects/SkColorMatrixFilter.h b/include/effects/SkColorMatrixFilter.h
index eee99271573b1e7c11b193c2f250e99cd6497f63..5cfa46896b442f6b6280ee27eb3178cfa8f2267b 100644
--- a/include/effects/SkColorMatrixFilter.h
+++ b/include/effects/SkColorMatrixFilter.h
@@ -39,14 +39,10 @@ public:
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkColorMatrixFilter)
 
 protected:
-    SkColorMatrixFilter(SkReadBuffer& buffer);
-    virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
-
-#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
-public:
-#endif
     explicit SkColorMatrixFilter(const SkColorMatrix&);

[scroggo, 2014/05/15 14:56:42]

Not picking on SkColorMatrixFilter in particular, but are there any of these
that we do not want anyone subclassing? If so, would it make sense to make their
constructors private?

(I'm not necessarily advocating that we make constructors private, but I just
want to make sure we deliberately chose protected instead.)

-    SkColorMatrixFilter(const SkScalar array[20]);
+    explicit SkColorMatrixFilter(const SkScalar array[20]);
+    explicit SkColorMatrixFilter(SkReadBuffer& buffer);
+    virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
 
 private:
     SkColorMatrix fMatrix;