Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.h

Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)
Patch Set: test fix: replace snapshot controller at the right place Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h
index 1c70970882d444693d828273914cc5dbc7f26870..bc83a224a8805a5528a8ec2b1cf32f237eca7937 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h
@@ -58,7 +58,8 @@ class BackgroundLoaderOffliner : public Offliner,
// SnapshotController::Client implementation.
void StartSnapshot() override;
- void SetPageDelayForTest(long delay_ms);
+ void SetSnapshotControllerForTest(
+ std::unique_ptr<SnapshotController> controller);
void OnNetworkBytesChanged(int64_t bytes);
protected:
@@ -111,8 +112,6 @@ class BackgroundLoaderOffliner : public Offliner,
SaveState save_state_;
// Page load state.
PageLoadState page_load_state_;
- // Seconds to delay before taking snapshot.
- long page_delay_ms_;
// Network bytes loaded.
int64_t network_bytes_;
// Whether the low bar of snapshot quality has been met.
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698