Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2822023002: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)
Patch Set: test fix: replace snapshot controller at the right place Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index 96dd8c08b205a2ed8ffb370110bf4cda6acfd4ce..856ada6fc7f47432e2bcfc803c7fcacd9553199a 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -28,8 +28,6 @@
namespace offline_pages {
namespace {
-const long kOfflinePageDelayMs = 2000;
-const long kOfflineDomContentLoadedMs = 25000;
const char kContentType[] = "text/plain";
const char kContentTransferEncodingBinary[] =
"Content-Transfer-Encoding: binary";
@@ -94,7 +92,6 @@ BackgroundLoaderOffliner::BackgroundLoaderOffliner(
is_low_end_device_(base::SysInfo::IsLowEndDevice()),
save_state_(NONE),
page_load_state_(SUCCESS),
- page_delay_ms_(kOfflinePageDelayMs),
network_bytes_(0LL),
is_low_bar_met_(false),
did_snapshot_on_last_retry_(false),
@@ -193,9 +190,8 @@ bool BackgroundLoaderOffliner::LoadAndSave(
// Load page attempt.
loader_.get()->LoadPage(request.url());
- snapshot_controller_.reset(
- new SnapshotController(base::ThreadTaskRunnerHandle::Get(), this,
- kOfflineDomContentLoadedMs, page_delay_ms_));
+ snapshot_controller_ = SnapshotController::CreateForBackgroundOfflining(
+ base::ThreadTaskRunnerHandle::Get(), this);
return true;
}
@@ -313,8 +309,9 @@ void BackgroundLoaderOffliner::DidFinishNavigation(
}
}
-void BackgroundLoaderOffliner::SetPageDelayForTest(long delay_ms) {
- page_delay_ms_ = delay_ms;
+void BackgroundLoaderOffliner::SetSnapshotControllerForTest(
+ std::unique_ptr<SnapshotController> controller) {
+ snapshot_controller_ = std::move(controller);
}
void BackgroundLoaderOffliner::OnNetworkBytesChanged(int64_t bytes) {

Powered by Google App Engine
This is Rietveld 408576698