Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2821973003: bluetooth: Add RSSI icon for bluetooth choosers. (Closed)

Created:
3 years, 8 months ago by ortuno
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add RSSI icon for bluetooth choosers. So that users can more easily identify the devices that are near them. BUG=629689 Review-Url: https://codereview.chromium.org/2821973003 Cr-Commit-Position: refs/heads/master@{#466230} Committed: https://chromium.googlesource.com/chromium/src/+/a973e918a51467c001a313ba91ebb69c69478b65

Patch Set 1 #

Patch Set 2 : Improve tests #

Patch Set 3 : clean up #

Total comments: 2

Patch Set 4 : #757575 -> @color/google_grey_600 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -22 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/res/drawable/ic_bluetooth_connected.xml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A + chrome/android/java/res/drawable/ic_signal_cellular_1_bar.xml View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
A + chrome/android/java/res/drawable/ic_signal_cellular_2_bar.xml View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
A + chrome/android/java/res/drawable/ic_signal_cellular_3_bar.xml View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
A + chrome/android/java/res/drawable/ic_signal_cellular_4_bar.xml View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java View 1 2 4 chunks +26 lines, -8 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java View 1 2 2 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/bluetooth_chooser_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
ortuno
dtrainor: PTAL. This patch uses an array of drawables instead of a LevelListDrawable because of ...
3 years, 8 months ago (2017-04-18 06:59:02 UTC) #2
David Trainor- moved to gerrit
lgtm m https://codereview.chromium.org/2821973003/diff/40001/chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml File chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml (right): https://codereview.chromium.org/2821973003/diff/40001/chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml#newcode14 chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml:14: android:fillColor="#757575"/> @color/google_grey_600 for all of these?
3 years, 8 months ago (2017-04-19 21:29:20 UTC) #7
ortuno
Thanks! https://codereview.chromium.org/2821973003/diff/40001/chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml File chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml (right): https://codereview.chromium.org/2821973003/diff/40001/chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml#newcode14 chrome/android/java/res/drawable/ic_signal_cellular_0_bar.xml:14: android:fillColor="#757575"/> On 2017/04/19 at 21:29:20, David Trainor-ping if ...
3 years, 8 months ago (2017-04-19 22:47:23 UTC) #8
ortuno
jbudorick: PTAL at build/android/lint/supressions.xml
3 years, 8 months ago (2017-04-19 22:48:07 UTC) #10
jbudorick
On 2017/04/19 22:48:07, ortuno wrote: > jbudorick: PTAL at build/android/lint/supressions.xml lgtm
3 years, 8 months ago (2017-04-21 01:31:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821973003/60001
3 years, 8 months ago (2017-04-21 01:33:16 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 02:13:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a973e918a51467c001a313ba91eb...

Powered by Google App Engine
This is Rietveld 408576698