[ES6 modules] Minor fixes to v8::ScriptModule

[ES6 modules] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call v8::TryCatch::SetVerbose(true), so that the instantiation errors will be reported to devtools console.

BUG=594639
Review-Url: https://codereview.chromium.org/2821903002
Cr-Commit-Position: refs/heads/master@{#464911}
Committed: https://chromium.googlesource.com/chromium/src/+/782c68372ded66d885ebd848bace62d639998dfc

[kouhei (in TOK), 2017-04-17 06:25:12]

kouhei@chromium.org changed reviewers:
+ adamk@chromium.org, haraken@chromium.org, yhirano@chromium.org

[kouhei (in TOK), 2017-04-17 06:25:16]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 06:25:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2017-04-17 06:32:41]

Description was changed from

==========
[ES6 module] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of
EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions
thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call SetVerbose(true), so that the instantiation errors will be reported to
devtools console.

BUG=594639
==========

to

==========
[ES6 modules] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of
EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions
thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call SetVerbose(true), so that the instantiation errors will be reported to
devtools console.

BUG=594639
==========

[kouhei (in TOK), 2017-04-17 06:36:36]

Description was changed from

==========
[ES6 modules] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of
EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions
thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call SetVerbose(true), so that the instantiation errors will be reported to
devtools console.

BUG=594639
==========

to

==========
[ES6 modules] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of
EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions
thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call v8::TryCatch::SetVerbose(true), so that the instantiation errors will be
reported to devtools console.

BUG=594639
==========

[haraken, 2017-04-17 07:34:30]

LGTM

[kouhei (in TOK), 2017-04-17 07:36:54]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-04-17 07:36:54]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2821903002/#ps20001
(title: "actually setverbose")

[commit-bot: I haz the power, 2017-04-17 07:37:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 09:12:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492414614451360,
"parent_rev": "6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b", "commit_rev":
"782c68372ded66d885ebd848bace62d639998dfc"}

[commit-bot: I haz the power, 2017-04-17 09:12:46]

Description was changed from

==========
[ES6 modules] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of
EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions
thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call v8::TryCatch::SetVerbose(true), so that the instantiation errors will be
reported to devtools console.

BUG=594639
==========

to

==========
[ES6 modules] Minor fixes to v8::ScriptModule

ScriptModule::Evaluate
- Make it a const method.
- Clarify a TODO that we don't currently have a codepath which use result of
EvaluateModule.
-- Spec "run a module script" Step 7 currently only cares about exceptions
thrown, and not about return value from successful completion.
-- https://html.spec.whatwg.org/multipage/webappapis.html#run-a-module-script

ScriptModule::Instantiate
- Call v8::TryCatch::SetVerbose(true), so that the instantiation errors will be
reported to devtools console.

BUG=594639

Review-Url: https://codereview.chromium.org/2821903002
Cr-Commit-Position: refs/heads/master@{#464911}
Committed:
https://chromium.googlesource.com/chromium/src/+/782c68372ded66d885ebd848bace...
==========

[commit-bot: I haz the power, 2017-04-17 09:12:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/782c68372ded66d885ebd848bace...

[adamk, 2017-04-17 17:39:43]

lgtm, thanks for fixing my TODO and adding the documenting comments