Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2821843002: Delete deprecated properties zoom:reset and zoom:document. (Closed)

Created:
3 years, 8 months ago by Bret
Modified:
3 years, 7 months ago
Reviewers:
Timothy Loh, ravi.webdreams
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-frames_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete deprecated properties zoom:reset and zoom:document. BUG=664668, 642613 Review-Url: https://codereview.chromium.org/2821843002 Cr-Commit-Position: refs/heads/master@{#467454} Committed: https://chromium.googlesource.com/chromium/src/+/36095a2996117ee0b77d0badc9b237ea4d686521

Patch Set 1 #

Patch Set 2 : rebase-update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
D third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bret
3 years, 8 months ago (2017-04-25 21:57:56 UTC) #7
Timothy Loh
On 2017/04/25 21:57:56, Bret Sepulveda wrote: lgtm!
3 years, 8 months ago (2017-04-26 01:32:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821843002/20001
3 years, 8 months ago (2017-04-26 18:48:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/36095a2996117ee0b77d0badc9b237ea4d686521
3 years, 8 months ago (2017-04-26 21:04:40 UTC) #13
ravi.webdreams_gmail.com
What type of error is this? On Wednesday, April 26, 2017 at 3:27:57 AM UTC+5:30, ...
3 years, 7 months ago (2017-05-09 04:50:36 UTC) #14
ravi.webdreams_gmail.com
3 years, 7 months ago (2017-05-09 04:50:37 UTC) #15
Message was sent while issue was closed. 
What type of error is this?

On Wednesday, April 26, 2017 at 3:27:57 AM UTC+5:30, bs...@chromium.org 
wrote:
>
> Reviewers: Timothy Loh
> CL: https://codereview.chromium.org/2821843002/
>
> Description:
> Delete deprecated properties zoom:reset and zoom:document.
>
> BUG=664668,642613
>
> Affected files (+1, -37 lines):
> D third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
> D 
>
third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt
> M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
> M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
> M third_party/WebKit/Source/core/frame/Deprecation.cpp
> M third_party/WebKit/Source/core/frame/UseCounter.h
>
>
> Index: 
>
third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt
> diff --git 
>
a/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt

>
b/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt
> deleted file mode 100644
> index 
>
ae000bfdc664982bb84bf1bf880f541955fabc4d..0000000000000000000000000000000000000000
> --- 
>
a/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -CONSOLE WARNING: "zoom: reset" is deprecated and will be removed in M59, 
> around June 2017. See 
> https://www.chromestatus.com/features/4997605029314560 for more details.
> -CONSOLE WARNING: "zoom: document" is deprecated and will be removed in 
> M59, around June 2017. See 
> https://www.chromestatus.com/features/4997605029314560 for more details.
> -
> Index: 
> third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
> diff --git 
> a/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html 
> b/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
> deleted file mode 100644
> index 
>
9f52d01aace4cfb7297532003f40b40d7deb7735..0000000000000000000000000000000000000000
> --- 
> a/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -<!DOCTYPE html>
> -<head>
> -<script>
> -if (window.testRunner)
> - testRunner.dumpAsText();
> -</script>
> -</head>
> -<body>
> -<div style="zoom:reset"></div>
> -<div style="zoom:document"></div>
> -</body>
> Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
> diff --git 
> a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp 
> b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
> index 
>
a1abb7e8f5b9fe0992e0a7ea262626a4aa3bfb81..2d94b6fbfa07ad8bdcdaf47110bfe76489107ec7

> 100644
> --- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
> +++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
> @@ -17,8 +17,7 @@ const CSSValue* CSSPropertyAPIZoom::parseSingleValue(
> const CSSParserToken& token = range.Peek();
> CSSValue* zoom = nullptr;
> if (token.GetType() == kIdentToken) {
> - zoom = CSSPropertyParserHelpers::ConsumeIdent<CSSValueNormal, 
> CSSValueReset,
> - CSSValueDocument>(range);
> + zoom = CSSPropertyParserHelpers::ConsumeIdent<CSSValueNormal>(range);
> } else {
> zoom =
> CSSPropertyParserHelpers::ConsumePercent(range, kValueRangeNonNegative);
> @@ -34,10 +33,6 @@ const CSSValue* CSSPropertyAPIZoom::parseSingleValue(
> (token.GetType() == kPercentageToken &&
> ToCSSPrimitiveValue(zoom)->GetDoubleValue() == 100)))
> context.Count(UseCounter::kCSSZoomNotEqualToOne);
> - if (token.Id() == CSSValueReset)
> - context.CountDeprecation(UseCounter::kCSSZoomReset);
> - if (token.Id() == CSSValueDocument)
> - context.CountDeprecation(UseCounter::kCSSZoomDocument);
> }
> return zoom;
> }
> Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
> diff --git 
> a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp 
> b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
> index 
>
b44925bed08f099a2ad791ae7fb6780cdcfc35e9..d9a49cbf41c5da51936754072342c503d0f29c72

> 100644
> --- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
> +++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
> @@ -552,15 +552,6 @@ void 
> StyleBuilderFunctions::applyValueCSSPropertyZoom(StyleResolverState& state,
> if (identifier_value.GetValueID() == CSSValueNormal) {
> ResetEffectiveZoom(state);
> state.SetZoom(ComputedStyle::InitialZoom());
> - } else if (identifier_value.GetValueID() == CSSValueReset) {
> - state.SetEffectiveZoom(ComputedStyle::InitialZoom());
> - state.SetZoom(ComputedStyle::InitialZoom());
> - } else if (identifier_value.GetValueID() == CSSValueDocument) {
> - float doc_zoom = state.RootElementStyle()
> - ? state.RootElementStyle()->Zoom()
> - : ComputedStyle::InitialZoom();
> - state.SetEffectiveZoom(doc_zoom);
> - state.SetZoom(doc_zoom);
> }
> } else if (value.IsPrimitiveValue()) {
> const CSSPrimitiveValue& primitive_value = ToCSSPrimitiveValue(value);
> Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
> diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp 
> b/third_party/WebKit/Source/core/frame/Deprecation.cpp
> index 
>
ab4370b6f94e5dc5cd55890252cad1a0a6d71dde..2eb92b60e75e38af3e915a959ec7c0e408c8151d

> 100644
> --- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
> +++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
> @@ -383,12 +383,6 @@ String 
> Deprecation::DeprecationMessage(UseCounter::Feature feature) {
> "-internal-media-controls-overlay-cast-button selector", M61,
> "5714245488476160");
>
> - case UseCounter::kCSSZoomReset:
> - return willBeRemoved("\"zoom: reset\"", M59, "4997605029314560");
> -
> - case UseCounter::kCSSZoomDocument:
> - return willBeRemoved("\"zoom: document\"", M59, "4997605029314560");
> -
> case UseCounter::kSelectionAddRangeIntersect:
> return "The behavior that Selection.addRange() merges existing Range and "
> "the specified Range was removed. See "
> Index: third_party/WebKit/Source/core/frame/UseCounter.h
> diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h 
> b/third_party/WebKit/Source/core/frame/UseCounter.h
> index 
>
635004d8a1bf4789f74dc01d1f89e8e859efaa64..e6ba0a74674912733dad2789ad10d974dd78a2c3

> 100644
> --- a/third_party/WebKit/Source/core/frame/UseCounter.h
> +++ b/third_party/WebKit/Source/core/frame/UseCounter.h
> @@ -1198,8 +1198,6 @@ class CORE_EXPORT UseCounter {
> kPresentationConnectionListConnectionAvailableEventListener = 1555,
> kWebAudioAutoplayCrossOriginIframe = 1556,
> kVRGetDisplays = 1558,
> - kCSSZoomReset = 1578,
> - kCSSZoomDocument = 1579,
> kXSSAuditorBlockedScript = 1581,
> kXSSAuditorBlockedEntirePage = 1582,
> kXSSAuditorDisabled = 1583,
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698