Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2821823002: Fix dia dll coping on VS++2017 (Closed)

Created:
3 years, 8 months ago by drbasic
Modified:
3 years, 8 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dia dll coping on VS++2017 R=scottmg@chromium.org BUG=700524 Review-Url: https://codereview.chromium.org/2821823002 Cr-Commit-Position: refs/heads/master@{#464968} Committed: https://chromium.googlesource.com/chromium/src/+/23bf5051cc684eacd9a3519470b28017b036335c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
drbasic
When set GYP_MSVS_VERSION=2017 gclient sync failed on step where msdia140.dll should be copied into third_party\llvm-build\Release+Asserts\bin.
3 years, 8 months ago (2017-04-15 11:43:25 UTC) #1
Nico
On 2017/04/15 11:43:25, drbasic wrote: > When set GYP_MSVS_VERSION=2017 gclient sync failed on step where ...
3 years, 8 months ago (2017-04-15 11:47:19 UTC) #2
Nico
lgtm
3 years, 8 months ago (2017-04-17 17:58:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821823002/1
3 years, 8 months ago (2017-04-17 17:59:26 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 19:17:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23bf5051cc684eacd9a3519470b2...

Powered by Google App Engine
This is Rietveld 408576698