Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2821793003: [Extensions Bindings] Apply per-context restrictions to events (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Apply per-context restrictions to events Similar to functions, API events can be restricted on a per-context basis. Apply the same deletion logic to them if they are unavailable in the given context. Modify APIBinding unittests to reflect this, and add more comprehensive tests in NativeExtensionBindingsSystem to test APIs that can be partially-available to websites. BUG=653596 Review-Url: https://codereview.chromium.org/2821793003 Cr-Commit-Position: refs/heads/master@{#465736} Committed: https://chromium.googlesource.com/chromium/src/+/89c1673e0dd340f486eba92816998f839706d8f9

Patch Set 1 #

Patch Set 2 : add comments #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -7 lines) Patch
M extensions/renderer/api_binding.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/renderer/api_binding_unittest.cc View 1 2 4 chunks +19 lines, -7 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system_unittest.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Devlin
Hey folks, mind taking a look?
3 years, 8 months ago (2017-04-17 17:39:56 UTC) #11
jbroman
lgtm
3 years, 8 months ago (2017-04-19 18:56:30 UTC) #12
lazyboy
lgtm
3 years, 8 months ago (2017-04-19 19:37:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821793003/40001
3 years, 8 months ago (2017-04-19 19:39:53 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 20:40:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/89c1673e0dd340f486eba9281699...

Powered by Google App Engine
This is Rietveld 408576698