Move classes in the device.usb Mojo namespace to device.mojom

Move classes in the device.usb Mojo namespace to device.mojom

The USB Mojo service was added before there was clear guidance on what
namespace Mojo modules should use. The convention is now to use
foo.mojom.

The USB Mojo service implementation is still in the device::usb
namespace which violates the general Chromium style guide recommendation
to not use nested namespaces. This will be fixed in a later patch.

BUG=699790
Review-Url: https://codereview.chromium.org/2821723002
Cr-Commit-Position: refs/heads/master@{#465467}
Committed: https://chromium.googlesource.com/chromium/src/+/c961656d2eb17624ee36f3bde2617aa73fb6f246

[Reilly Grant (use Gerrit), 2017-04-14 19:29:16]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 19:29:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-04-14 19:30:10]

reillyg@chromium.org changed reviewers:
+ mcasas@chromium.org

[Reilly Grant (use Gerrit), 2017-04-14 19:30:10]

PTAL

[commit-bot: I haz the power, 2017-04-14 19:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 19:40:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Reilly Grant (use Gerrit), 2017-04-14 19:59:33]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 19:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-04-14 20:00:49]

reillyg@chromium.org changed reviewers:
+ mbarbella@chromium.org, miguelg@chromium.org

[Reilly Grant (use Gerrit), 2017-04-14 20:00:50]

+miguelg@ for */android/*
+mbarbella@ for device/usb/public/interfaces/* and
chrome/browser/chrome_content_browser_manifest_overlay.json

[commit-bot: I haz the power, 2017-04-14 20:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 20:27:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Reilly Grant (use Gerrit), 2017-04-14 21:00:30]

fix usb_descriptors_fuzzer

[Reilly Grant (use Gerrit), 2017-04-14 21:13:23]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 21:13:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-04-14 22:00:46]

lgtm with some minor things

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_manifest_overlay.json (right):

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_manifest_overlay.json:43:
"chrome::mojom::OpenSearchDocumentDescriptionHandler",
Oh, this one should go before the previous line.

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_manifest_overlay.json:46:
"contextual_search::mojom::ContextualSearchJsApiService",
Ugh and this should go in l.43.

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_chooser_controller.cc (right):

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_chooser_controller.cc:165:
callback_.Run(std::move(device_info_ptr));
nit:
  callback_.Run(device::mojom::UsbDeviceInfo::From(*devices_[index].first));
?
(under 80 chars, yay!)

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/device_...
File device/usb/mojo/device_impl.cc (right):

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/device_...
device/usb/mojo/device_impl.cc:109: void
DeviceImpl::Create(scoped_refptr<device::UsbDevice> device,
Same here, aren't we in device::usb namespace? 
There shouldn't be need for disambiguation, or is
there a device::UsbDevice and a device::usb::UsbDevice?

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/device_...
File device/usb/mojo/device_impl.h (right):

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/device_...
device/usb/mojo/device_impl.h:103: const scoped_refptr<device::UsbDevice>
device_;
device:: namespace indication shouldn't be needed?
Same in l.32 and l.39.

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/type_co...
File device/usb/mojo/type_converters.cc (right):

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/type_co...
device/usb/mojo/type_converters.cc:192:
device::mojom::UsbConfigurationInfo::New();
I'd say it's ok to do here
  auto info = device::mojom::UsbConfigurationInfo::New();

and similar MojoStruct::New() cases

[Reilly Grant (use Gerrit), 2017-04-14 22:13:18]

mcasas@ nits

[Reilly Grant (use Gerrit), 2017-04-14 22:15:30]

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_manifest_overlay.json (right):

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_manifest_overlay.json:43:
"chrome::mojom::OpenSearchDocumentDescriptionHandler",
On 2017/04/14 22:00:46, mcasas wrote:
> Oh, this one should go before the previous line.

Done.

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_manifest_overlay.json:46:
"contextual_search::mojom::ContextualSearchJsApiService",
On 2017/04/14 22:00:46, mcasas wrote:
> Ugh and this should go in l.43.

Done.

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_chooser_controller.cc (right):

https://codereview.chromium.org/2821723002/diff/40001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_chooser_controller.cc:165:
callback_.Run(std::move(device_info_ptr));
On 2017/04/14 22:00:46, mcasas wrote:
> nit:
>   callback_.Run(device::mojom::UsbDeviceInfo::From(*devices_[index].first));
> ?
> (under 80 chars, yay!)

Done.

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/device_...
File device/usb/mojo/device_impl.h (right):

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/device_...
device/usb/mojo/device_impl.h:103: const scoped_refptr<device::UsbDevice>
device_;
On 2017/04/14 22:00:46, mcasas wrote:
> device:: namespace indication shouldn't be needed?
> Same in l.32 and l.39.

I scratched my head over this for a long time and I think what is going on is
that by extending mojom::UsbDevice the symbol UsbDevice is brought into scope as
meaning the superclass and so overrides the symbol UsbDevice from the containing
namespace.

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/type_co...
File device/usb/mojo/type_converters.cc (right):

https://codereview.chromium.org/2821723002/diff/40001/device/usb/mojo/type_co...
device/usb/mojo/type_converters.cc:192:
device::mojom::UsbConfigurationInfo::New();
On 2017/04/14 22:00:46, mcasas wrote:
> I'd say it's ok to do here
>   auto info = device::mojom::UsbConfigurationInfo::New();
> 
> and similar MojoStruct::New() cases

Done.

[Reilly Grant (use Gerrit), 2017-04-14 22:16:09]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 22:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 23:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 23:54:49]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-04-18 15:48:51]

Friendly ping.

[Miguel Garcia, 2017-04-18 15:51:45]

Apologies for the delay, London was out Friday and Monday due to Easter holidays

*/android/* LGTM

[Martin Barbella, 2017-04-18 23:54:14]

security lgtm

[Reilly Grant (use Gerrit), 2017-04-19 00:13:20]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-04-19 00:13:20]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2821723002/#ps60001
(title: "mcasas@ nits")

[commit-bot: I haz the power, 2017-04-19 00:14:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 02:06:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492560800179290,
"parent_rev": "17bdec384af8e7b76ee898feccbc6360d8b81f17", "commit_rev":
"c961656d2eb17624ee36f3bde2617aa73fb6f246"}

[commit-bot: I haz the power, 2017-04-19 02:06:26]

Description was changed from

==========
Move classes in the device.usb Mojo namespace to device.mojom

The USB Mojo service was added before there was clear guidance on what
namespace Mojo modules should use. The convention is now to use
foo.mojom.

The USB Mojo service implementation is still in the device::usb
namespace which violates the general Chromium style guide recommendation
to not use nested namespaces. This will be fixed in a later patch.

BUG=699790
==========

to

==========
Move classes in the device.usb Mojo namespace to device.mojom

The USB Mojo service was added before there was clear guidance on what
namespace Mojo modules should use. The convention is now to use
foo.mojom.

The USB Mojo service implementation is still in the device::usb
namespace which violates the general Chromium style guide recommendation
to not use nested namespaces. This will be fixed in a later patch.

BUG=699790

Review-Url: https://codereview.chromium.org/2821723002
Cr-Commit-Position: refs/heads/master@{#465467}
Committed:
https://chromium.googlesource.com/chromium/src/+/c961656d2eb17624ee36f3bde261...
==========

[commit-bot: I haz the power, 2017-04-19 02:06:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c961656d2eb17624ee36f3bde261...