[tools/perf] Remove default values of benchmark_dirs and top_level_dir in chromium_config module

[tools/perf] Remove default values of benchmark_dirs and top_level_dir in chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need 
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org

Review-Url: https://codereview.chromium.org/2821663002
Cr-Commit-Position: refs/heads/master@{#465016}
Committed: https://chromium.googlesource.com/chromium/src/+/09cd8622560496d63dd16d0b10a7c515dbc5c3ff

[nednguyen, 2017-04-14 14:15:51]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 14:16:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-04-14 14:16:19]

nednguyen@google.com changed reviewers:
+ ashleymarie@chromium.org, martiniss@chromium.org, perezju@chromium.org

[nednguyen, 2017-04-14 14:16:36]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them, later I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need to
default the value of benchmark_dirs & top_level_dir.

BUG=709063
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need to
default the value of benchmark_dirs & top_level_dir.

BUG=709063
==========

[nednguyen, 2017-04-14 14:16:57]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need to
default the value of benchmark_dirs & top_level_dir.

BUG=709063
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need 
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
==========

[commit-bot: I haz the power, 2017-04-14 15:19:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 15:19:02]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-04-17 10:22:21]

On 2017/04/14 14:16:19, nednguyen wrote:

ping

[martiniss, 2017-04-17 19:42:48]

lgtm

https://codereview.chromium.org/2821663002/diff/1/tools/perf/chrome_telemetry...
File tools/perf/chrome_telemetry_build/chromium_config.py (right):

https://codereview.chromium.org/2821663002/diff/1/tools/perf/chrome_telemetry...
tools/perf/chrome_telemetry_build/chromium_config.py:22:
default_chrome_root=path_util.GetChromiumSrcDir()):
nit: I'm not used to putting function calls in default arguments in python.
Usually I do default_chrome_root=None, and check below if the value is set. Up
to you. I don't think there's any urgent need to change this, like you should
change default arguments of lists.

[nednguyen, 2017-04-17 19:55:25]

https://codereview.chromium.org/2821663002/diff/1/tools/perf/chrome_telemetry...
File tools/perf/chrome_telemetry_build/chromium_config.py (right):

https://codereview.chromium.org/2821663002/diff/1/tools/perf/chrome_telemetry...
tools/perf/chrome_telemetry_build/chromium_config.py:22:
default_chrome_root=path_util.GetChromiumSrcDir()):
On 2017/04/17 19:42:48, martiniss wrote:
> nit: I'm not used to putting function calls in default arguments in python.
> Usually I do default_chrome_root=None, and check below if the value is set. Up
> to you. I don't think there's any urgent need to change this, like you should
> change default arguments of lists.

Good point, there is the risk that this is changed to return a list. I will
update it to None as you propose.

[nednguyen, 2017-04-17 19:59:31]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-04-17 19:59:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2821663002/#ps20001
(title: "Address martiniss@'s comment")

[commit-bot: I haz the power, 2017-04-17 20:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:00:02]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[nednguyen, 2017-04-17 20:00:28]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need 
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need 
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org
==========

[nednguyen, 2017-04-17 20:00:36]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2017-04-17 20:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:12:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492459236581870,
"parent_rev": "d6560d2fd7a498e06d8547a0b0b86bc948a24b5c", "commit_rev":
"09cd8622560496d63dd16d0b10a7c515dbc5c3ff"}

[commit-bot: I haz the power, 2017-04-17 21:12:38]

Description was changed from

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need 
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org
==========

to

==========
[tools/perf] Remove default values of benchmark_dirs and top_level_dir in
chromium_config module

Part of this CL also moves GetChromiumSrcDir & GetTelemetryDir methods to
tools.perf.core.path_util module

Motivation: to move experiemental benchmarks to a separate folder & still
make run_benchmarks be able to detect them,  I will need to modify
run_benchmarks to also include experiemental benchmark folder in
|benchmark_dirs| parameter. Upon doing that, I find that there is no need 
to set the default the value of benchmark_dirs & top_level_dir.

BUG=709063
TBR=perezju@chromium.org

Review-Url: https://codereview.chromium.org/2821663002
Cr-Commit-Position: refs/heads/master@{#465016}
Committed:
https://chromium.googlesource.com/chromium/src/+/09cd8622560496d63dd16d0b10a7...
==========

[commit-bot: I haz the power, 2017-04-17 21:12:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09cd8622560496d63dd16d0b10a7...

[alexmos, 2017-04-17 22:06:08]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2823063003/ by alexmos@chromium.org.

The reason for reverting is: Suspected to be breaking various tests, e.g.: 

https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%2...

https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20%28NVIDI...

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/39799

The logs show a python failure similar to

Traceback (most recent call last): File
"../../content/test/gpu/run_unittests.py", line 15, in <module>
path_util.SetupTelemetryPaths() File
"/b/swarm_slave/w/ir/content/test/gpu/gpu_tests/path_util.py", line 31, in
SetupTelemetryPaths from chrome_telemetry_build import chromium_config File
"/b/swarm_slave/w/ir/tools/perf/chrome_telemetry_build/chromium_config.py", line
7, in <module> from core import path_util ImportError: No module named core .