Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2821623002:
Add michaelpg to extensions/shell/OWNERS (Closed)
DescriptionAdd michaelpg to extensions/shell/OWNERS
and correct the component.
BUG=none
Review-Url: https://codereview.chromium.org/2821623002
Cr-Commit-Position: refs/heads/master@{#465733}
Committed: https://chromium.googlesource.com/chromium/src/+/cb7c7859e8e84236d85aca12005c22ce707ebee4
Patch Set 1 #Patch Set 2 : update component #
Total comments: 5
Patch Set 3 : . #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Add michaelpg to extensions/shell/OWNERS BUG=none ========== to ========== Add michaelpg to extensions/shell/OWNERS and correct the component. BUG=none ==========
michaelpg@chromium.org changed reviewers: + derat@chromium.org, rkc@chromium.org
michaelpg@chromium.org changed required reviewers: + rkc@chromium.org
PTAL :-) https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS File extensions/shell/OWNERS (right): https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS... extensions/shell/OWNERS:1: derat@chromium.org dan, do you still want to be listed here?
derat@chromium.org changed reviewers: + jamescook@chromium.org
https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS File extensions/shell/OWNERS (right): https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS... extensions/shell/OWNERS:1: derat@chromium.org On 2017/04/14 01:12:21, michaelpg wrote: > dan, do you still want to be listed here? if you guys are going to own this, i'm fine with you dropping me. james?
lgtm
I'm fine with you dropping me as well. LGTM
https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS File extensions/shell/OWNERS (right): https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS... extensions/shell/OWNERS:6: # TEAM: extensions-dev@chromium.org apps-dev?
also dropped dan & james and added devlin as requested https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS File extensions/shell/OWNERS (right): https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS... extensions/shell/OWNERS:1: derat@chromium.org On 2017/04/14 04:37:53, Daniel Erat wrote: > On 2017/04/14 01:12:21, michaelpg wrote: > > dan, do you still want to be listed here? > > if you guys are going to own this, i'm fine with you dropping me. james? Done. https://codereview.chromium.org/2821623002/diff/20001/extensions/shell/OWNERS... extensions/shell/OWNERS:6: # TEAM: extensions-dev@chromium.org On 2017/04/17 18:35:56, rkc wrote: > apps-dev? Done.
lgtm
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamescook@chromium.org, derat@chromium.org Link to the patchset: https://codereview.chromium.org/2821623002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492633460079480,
"parent_rev": "476724766017697a95a37e4b29db33005b075dbb", "commit_rev":
"cb7c7859e8e84236d85aca12005c22ce707ebee4"}
Message was sent while issue was closed.
Description was changed from ========== Add michaelpg to extensions/shell/OWNERS and correct the component. BUG=none ========== to ========== Add michaelpg to extensions/shell/OWNERS and correct the component. BUG=none Review-Url: https://codereview.chromium.org/2821623002 Cr-Commit-Position: refs/heads/master@{#465733} Committed: https://chromium.googlesource.com/chromium/src/+/cb7c7859e8e84236d85aca12005c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/cb7c7859e8e84236d85aca12005c... |
