Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2821523002: [layoutng] Use correct writing mode for overflow rect (Closed)

Created:
3 years, 8 months ago by cbiesinger
Modified:
3 years, 8 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Use correct writing mode for overflow rect Specifically for the case when we create a fragment from the result from old layout. R=ikilpatrick@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2821523002 Cr-Commit-Position: refs/heads/master@{#464635} Committed: https://chromium.googlesource.com/chromium/src/+/84a681389ab3960b8db073bda33d98845aba7488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
cbiesinger
3 years, 8 months ago (2017-04-13 20:30:25 UTC) #1
ikilpatrick
lgtm
3 years, 8 months ago (2017-04-14 00:36:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821523002/1
3 years, 8 months ago (2017-04-14 00:37:26 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:56:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84a681389ab3960b8db073bda33d...

Powered by Google App Engine
This is Rietveld 408576698