Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: android_webview/browser/aw_content_browser_client.h

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)
Patch Set: MakeShared goodness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.h
diff --git a/android_webview/browser/aw_content_browser_client.h b/android_webview/browser/aw_content_browser_client.h
index 8dcff05d5d7ddc6ad0a4c33e5d6197864fe7f5f0..4a240ff2fe95afe7f0e832b232df053f0eec4181 100644
--- a/android_webview/browser/aw_content_browser_client.h
+++ b/android_webview/browser/aw_content_browser_client.h
@@ -91,8 +91,7 @@ class AwContentBrowserClient : public content::ContentBrowserClient {
content::WebContents* web_contents,
net::SSLCertRequestInfo* cert_request_info,
std::unique_ptr<content::ClientCertificateDelegate> delegate) override;
- bool CanCreateWindow(int opener_render_process_id,
- int opener_render_frame_id,
+ bool CanCreateWindow(content::RenderFrameHost* opener,
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
@@ -104,7 +103,6 @@ class AwContentBrowserClient : public content::ContentBrowserClient {
const blink::mojom::WindowFeatures& features,
bool user_gesture,
bool opener_suppressed,
- content::ResourceContext* context,
bool* no_javascript_access) override;
void ResourceDispatcherHostCreated() override;
net::NetLog* GetNetLog() override;
« no previous file with comments | « no previous file | android_webview/browser/aw_content_browser_client.cc » ('j') | content/test/test_render_frame.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698