Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2425)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2821473002: Service CreateNewWindow on the UI thread with a new mojo interface (Closed)
Patch Set: MakeShared goodness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/android/webapps/single_tab_mode_tab_helper.h » ('j') | content/test/test_render_frame.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 8fe2e7c4e1fe5653d44da66cf718f274239d05e9..f717f83de334bc1b77ca4cf6608f71705c3b13d9 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -404,8 +404,7 @@ void AwContentBrowserClient::SelectClientCertificate(
}
bool AwContentBrowserClient::CanCreateWindow(
- int opener_render_process_id,
- int opener_render_frame_id,
+ content::RenderFrameHost* opener,
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
@@ -417,7 +416,6 @@ bool AwContentBrowserClient::CanCreateWindow(
const blink::mojom::WindowFeatures& features,
bool user_gesture,
bool opener_suppressed,
- content::ResourceContext* context,
bool* no_javascript_access) {
// We unconditionally allow popup windows at this stage and will give
// the embedder the opporunity to handle displaying of the popup in
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/android/webapps/single_tab_mode_tab_helper.h » ('j') | content/test/test_render_frame.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698