Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2821463004: Revert of Fix layout of BubbleFrameView when there's only a close button in the (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
CC:
chromium-reviews, msw+watch_chromium.org, groby+bubble_chromium.org, rouslan+bubble_chromium.org, hcarmona+bubble_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix layout of BubbleFrameView when there's only a close button in the (patchset #5 id:40002 of https://codereview.chromium.org/2807243004/ ) Reason for revert: Breaks DialogTest.AcceptAndCancel on a couple of bots (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/59105 and https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24880). Original issue's description: > Fix layout of BubbleFrameView when there's only a close button in the > title row. > > Push the client area down slightly so it doesn't overlap close. This > is a bandaid until bug 702196 is fixed. > > BUG=709380, 702196 TBR=tapted@chromium.org,pkasting@chromium.org,bsep@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=709380, 702196 Review-Url: https://codereview.chromium.org/2821463004 Cr-Commit-Position: refs/heads/master@{#464773} Committed: https://chromium.googlesource.com/chromium/src/+/77227cc6631117209eb6cfbbc5c78bf0d3c8a4b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -64 lines) Patch
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/bubble/bubble_frame_view_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 7 chunks +23 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
alexmos
Created Revert of Fix layout of BubbleFrameView when there's only a close button in the
3 years, 8 months ago (2017-04-14 18:21:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821463004/1
3 years, 8 months ago (2017-04-14 18:22:03 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 19:26:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77227cc6631117209eb6cfbbc5c7...

Powered by Google App Engine
This is Rietveld 408576698